From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wentao Guan <guanwentao@uniontech.com>
Cc: brgl@kernel.org, mathieu.dubois-briand@bootlin.com,
ioana.ciornei@nxp.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, zhanjun@uniontech.com,
niecheng1@uniontech.com, stable@vger.kernel.org,
WangYuli <wangyl5933@chinaunicom.cn>
Subject: Re: [PATCH v2] gpio: regmap: Fix memleak in gpio_remap_register
Date: Wed, 3 Dec 2025 16:50:49 +0200 [thread overview]
Message-ID: <aTBOSfH9KyI0epZB@smile.fi.intel.com> (raw)
In-Reply-To: <20251203141557.2652348-1-guanwentao@uniontech.com>
On Wed, Dec 03, 2025 at 10:15:58PM +0800, Wentao Guan wrote:
> We should call gpiochip_remove(chip) to free the resource
> alloced by gpiochip_add_data(chip, gpio) after the err path.
> Fixes: 553b75d4bfe9 ("gpio: regmap: Allow to allocate regmap-irq device")
As I told in v1, add the other Fixes tag, to show that the code was modified
and this change has a dependency to that.
...
With that done, it LGTM.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-12-03 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 14:15 [PATCH v2] gpio: regmap: Fix memleak in gpio_remap_register Wentao Guan
2025-12-03 14:50 ` Andy Shevchenko [this message]
2025-12-03 15:12 ` Wentao Guan
2025-12-03 16:58 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTBOSfH9KyI0epZB@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@kernel.org \
--cc=guanwentao@uniontech.com \
--cc=ioana.ciornei@nxp.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.dubois-briand@bootlin.com \
--cc=niecheng1@uniontech.com \
--cc=stable@vger.kernel.org \
--cc=wangyl5933@chinaunicom.cn \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).