From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Linus Walleij <linusw@kernel.org>,
Conor Dooley <conor.dooley@microchip.com>,
Arnd Bergmann <arnd@arndb.de>,
Bartosz Golaszewski <brgl@kernel.org>,
Yulin Lu <luyulin@eswincomputing.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: add CONFIG_OF dependencies for microchip drivers
Date: Thu, 4 Dec 2025 14:11:22 +0200 [thread overview]
Message-ID: <aTF6ai3PCK6B_EJI@smile.fi.intel.com> (raw)
In-Reply-To: <20251204095024.1031947-1-arnd@kernel.org>
On Thu, Dec 04, 2025 at 10:50:14AM +0100, Arnd Bergmann wrote:
>
> The two newly added drivers fail to link on builds without
> CONFIG_OF:
>
> x86_64-linux-ld: drivers/pinctrl/pinctrl-pic64gx-gpio2.o: in function `pinconf_generic_dt_node_to_map_all':
> pinctrl-pic64gx-gpio2.c:(.text+0xc9): undefined reference to `pinconf_generic_dt_node_to_map'
> x86_64-linux-ld: drivers/pinctrl/pinctrl-mpfs-iomux0.o: in function `pinconf_generic_dt_node_to_map_all':
> pinctrl-mpfs-iomux0.c:(.text+0xc9): undefined reference to `pinconf_generic_dt_node_to_map'
>
> Add a Kconfig dependencies.
This will reduce the compile test base. In other drivers we usually put
ifdeffery in the code.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-12-04 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 9:50 [PATCH] pinctrl: add CONFIG_OF dependencies for microchip drivers Arnd Bergmann
2025-12-04 10:07 ` Conor Dooley
2025-12-04 12:11 ` Andy Shevchenko [this message]
2025-12-04 13:44 ` Arnd Bergmann
2025-12-04 18:56 ` Andy Shevchenko
2025-12-04 19:40 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTF6ai3PCK6B_EJI@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=brgl@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luyulin@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).