[PATCH] gpio: swnode: restore the name of the undefined software node

[PATCH] gpio: swnode: restore the name of the undefined software node

[Bartosz Golaszewski]

Commit 6774a66d0e10 ("gpio: swnode: compare the "undefined" swnode by
its address, not name") switched to comparing the software nodes by
address instead of names but it's still useful to keep the name of the
node to expose the relevant information over sysfs. Restore the
human-readable name.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Closes: https://lore.kernel.org/all/aVFsjSIwrBw7tFLU@smile.fi.intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
 drivers/gpio/gpiolib-swnode.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib-swnode.c b/drivers/gpio/gpiolib-swnode.c
index 54bad9e88fe5..21478b45c127 100644
--- a/drivers/gpio/gpiolib-swnode.c
+++ b/drivers/gpio/gpiolib-swnode.c
@@ -138,7 +138,9 @@ int swnode_gpio_count(const struct fwnode_handle *fwnode, const char *con_id)
  * A special node that identifies undefined GPIOs, this is primarily used as
  * a key for internal chip selects in SPI bindings.
  */
-const struct software_node swnode_gpio_undefined = { };
+const struct software_node swnode_gpio_undefined = {
+	.name = "swnode-gpio-undefined",
+};
 EXPORT_SYMBOL_NS_GPL(swnode_gpio_undefined, "GPIO_SWNODE");
 
 static int __init swnode_gpio_init(void)
-- 
2.47.3

Re: [PATCH] gpio: swnode: restore the name of the undefined software node

[Andy Shevchenko]

On Fri, Jan 02, 2026 at 10:33:49AM +0100, Bartosz Golaszewski wrote:
> Commit 6774a66d0e10 ("gpio: swnode: compare the "undefined" swnode by
> its address, not name") switched to comparing the software nodes by
> address instead of names but it's still useful to keep the name of the
> node to expose the relevant information over sysfs. Restore the
> human-readable name.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] gpio: swnode: restore the name of the undefined software node

[Bartosz Golaszewski]

On Fri, 02 Jan 2026 10:33:49 +0100, Bartosz Golaszewski wrote:
> Commit 6774a66d0e10 ("gpio: swnode: compare the "undefined" swnode by
> its address, not name") switched to comparing the software nodes by
> address instead of names but it's still useful to keep the name of the
> node to expose the relevant information over sysfs. Restore the
> human-readable name.
> 
> 
> [...]

Applied, thanks!

[1/1] gpio: swnode: restore the name of the undefined software node
      commit: 98d78c06f54da101c1f2eb79af378cee9e07e102

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>