From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: linusw@kernel.org, andriy.shevchenko@intel.com,
dev-jorge.sanjuangarcia@duagon.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] gpio: gpio-menz127: drop unneeded MODULE_ALIAS
Date: Fri, 9 Jan 2026 12:30:42 +0100 [thread overview]
Message-ID: <aWDm4pjW83yta2Mx@MNI-190> (raw)
In-Reply-To: <CAMRc=McFDfVjpEBGzRpWiyH0D4q2eOApKZrJLFgh_UXQ=tDNMA@mail.gmail.com>
On Fri, Jan 09, 2026 at 09:31:30AM +0100, Bartosz Golaszewski wrote:
> On Thu, Jan 8, 2026 at 2:49 PM Jose Javier Rodriguez Barbarin
> <dev-josejavier.rodriguez@duagon.com> wrote:
> >
> > Since commit 1f4ea4838b13 ("mcb: Add missing modpost build support")
> > the MODULE_ALIAS() is redundant as the module alias is now
> > automatically generated from the MODULE_DEVICE_TABLE().
> >
> > Remove the explicit alias.
> >
> > No functional change intended.
> >
> > Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
> > Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
> > ---
>
> And what are the changes vs v1?
Hi Bartosz,
Thank you for your answer.
There is no changes in the code between v1 and v2. As I wrote in the cover
letter, the change for v2 is basically the commit renaming.
I know sending v2 without changes is not strictly correct but I decided to do that
because I make some mistakes the first time and I would like to clarify that.
I failed in first patch series submission as not all people involved received the
cover letter (among other mistakes) so I decided to send each patch as v2
(with its cover letter) to the correct people and mailing lists.
>
> Bart
>
> > drivers/gpio/gpio-menz127.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpio/gpio-menz127.c b/drivers/gpio/gpio-menz127.c
> > index 52b13c6ae496..f51e7517f551 100644
> > --- a/drivers/gpio/gpio-menz127.c
> > +++ b/drivers/gpio/gpio-menz127.c
> > @@ -223,5 +223,4 @@ module_mcb_driver(men_z127_driver);
> > MODULE_AUTHOR("Andreas Werner <andreas.werner@men.de>");
> > MODULE_DESCRIPTION("MEN GPIO Controller");
> > MODULE_LICENSE("GPL v2");
> > -MODULE_ALIAS("mcb:16z127");
> > MODULE_IMPORT_NS("MCB");
> > --
> > 2.52.0
Regards,
Javier R.
next prev parent reply other threads:[~2026-01-09 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 13:48 [PATCH v2 0/1] gpio: Remove MODULE_ALIAS from gpio-menz127 Jose Javier Rodriguez Barbarin
2026-01-08 13:48 ` [PATCH v2 1/1] gpio: gpio-menz127: drop unneeded MODULE_ALIAS Jose Javier Rodriguez Barbarin
2026-01-09 8:31 ` Bartosz Golaszewski
2026-01-09 11:30 ` Jose Javier Rodriguez Barbarin [this message]
2026-01-12 10:40 ` [PATCH v2 0/1] gpio: Remove MODULE_ALIAS from gpio-menz127 Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWDm4pjW83yta2Mx@MNI-190 \
--to=dev-josejavier.rodriguez@duagon.com \
--cc=andriy.shevchenko@intel.com \
--cc=brgl@kernel.org \
--cc=dev-jorge.sanjuangarcia@duagon.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox