public inbox for linux-gpio@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/1] gpio: Remove MODULE_ALIAS from gpio-menz127
@ 2026-01-08 13:48 Jose Javier Rodriguez Barbarin
  2026-01-08 13:48 ` [PATCH v2 1/1] gpio: gpio-menz127: drop unneeded MODULE_ALIAS Jose Javier Rodriguez Barbarin
  2026-01-12 10:40 ` [PATCH v2 0/1] gpio: Remove MODULE_ALIAS from gpio-menz127 Bartosz Golaszewski
  0 siblings, 2 replies; 5+ messages in thread
From: Jose Javier Rodriguez Barbarin @ 2026-01-08 13:48 UTC (permalink / raw)
  To: linusw, brgl
  Cc: andriy.shevchenko, dev-jorge.sanjuangarcia, linux-gpio,
	linux-kernel, Jose Javier Rodriguez Barbarin

The first patches I sent for fixing the autoload problem encountered
on mcb device drivers were 2. The first [1] was focused on updating the
modpost process for letting kbuild to access to the data within
MODULE_DEVICE_TABLE and the second one [2] for removing the MODULE_ALIAS
on all mcb client drivers.

They were rejected and Andy suggested me to split the second patch
in a per-driver basis instead of sending all drivers' changes in a
single patch once the first patch was merged.

The first patch is already merged on Linus's Git repository for 6.19-rc4

commit 1f4ea4838b13 ("mcb: Add missing modpost build support")

So now I am sending this patch for removing MODULE_ALIAS on the mcb driver
in this subsystem as it is no longer required. This cleanup is being sent
to each affected subsystem separately, as per the review suggestion to ease
the handling for maintainers.

[1] https://lore.kernel.org/all/20251127155452.42660-2-dev-josejavier.rodriguez@duagon.com/
[2] https://lore.kernel.org/all/20251127155452.42660-3-dev-josejavier.rodriguez@duagon.com/

changes in v2:
- Renane commit message

Jose Javier Rodriguez Barbarin (1):
  gpio: gpio-menz127: drop unneeded MODULE_ALIAS

 drivers/gpio/gpio-menz127.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.52.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/1] gpio: gpio-menz127: drop unneeded MODULE_ALIAS
  2026-01-08 13:48 [PATCH v2 0/1] gpio: Remove MODULE_ALIAS from gpio-menz127 Jose Javier Rodriguez Barbarin
@ 2026-01-08 13:48 ` Jose Javier Rodriguez Barbarin
  2026-01-09  8:31   ` Bartosz Golaszewski
  2026-01-12 10:40 ` [PATCH v2 0/1] gpio: Remove MODULE_ALIAS from gpio-menz127 Bartosz Golaszewski
  1 sibling, 1 reply; 5+ messages in thread
From: Jose Javier Rodriguez Barbarin @ 2026-01-08 13:48 UTC (permalink / raw)
  To: linusw, brgl
  Cc: andriy.shevchenko, dev-jorge.sanjuangarcia, linux-gpio,
	linux-kernel, Jose Javier Rodriguez Barbarin

Since commit 1f4ea4838b13 ("mcb: Add missing modpost build support")
the MODULE_ALIAS() is redundant as the module alias is now
automatically generated from the MODULE_DEVICE_TABLE().

Remove the explicit alias.

No functional change intended.

Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
---
 drivers/gpio/gpio-menz127.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-menz127.c b/drivers/gpio/gpio-menz127.c
index 52b13c6ae496..f51e7517f551 100644
--- a/drivers/gpio/gpio-menz127.c
+++ b/drivers/gpio/gpio-menz127.c
@@ -223,5 +223,4 @@ module_mcb_driver(men_z127_driver);
 MODULE_AUTHOR("Andreas Werner <andreas.werner@men.de>");
 MODULE_DESCRIPTION("MEN GPIO Controller");
 MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("mcb:16z127");
 MODULE_IMPORT_NS("MCB");
-- 
2.52.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/1] gpio: gpio-menz127: drop unneeded MODULE_ALIAS
  2026-01-08 13:48 ` [PATCH v2 1/1] gpio: gpio-menz127: drop unneeded MODULE_ALIAS Jose Javier Rodriguez Barbarin
@ 2026-01-09  8:31   ` Bartosz Golaszewski
  2026-01-09 11:30     ` Jose Javier Rodriguez Barbarin
  0 siblings, 1 reply; 5+ messages in thread
From: Bartosz Golaszewski @ 2026-01-09  8:31 UTC (permalink / raw)
  To: Jose Javier Rodriguez Barbarin
  Cc: linusw, andriy.shevchenko, dev-jorge.sanjuangarcia, linux-gpio,
	linux-kernel

On Thu, Jan 8, 2026 at 2:49 PM Jose Javier Rodriguez Barbarin
<dev-josejavier.rodriguez@duagon.com> wrote:
>
> Since commit 1f4ea4838b13 ("mcb: Add missing modpost build support")
> the MODULE_ALIAS() is redundant as the module alias is now
> automatically generated from the MODULE_DEVICE_TABLE().
>
> Remove the explicit alias.
>
> No functional change intended.
>
> Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
> Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
> ---

And what are the changes vs v1?

Bart

>  drivers/gpio/gpio-menz127.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-menz127.c b/drivers/gpio/gpio-menz127.c
> index 52b13c6ae496..f51e7517f551 100644
> --- a/drivers/gpio/gpio-menz127.c
> +++ b/drivers/gpio/gpio-menz127.c
> @@ -223,5 +223,4 @@ module_mcb_driver(men_z127_driver);
>  MODULE_AUTHOR("Andreas Werner <andreas.werner@men.de>");
>  MODULE_DESCRIPTION("MEN GPIO Controller");
>  MODULE_LICENSE("GPL v2");
> -MODULE_ALIAS("mcb:16z127");
>  MODULE_IMPORT_NS("MCB");
> --
> 2.52.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/1] gpio: gpio-menz127: drop unneeded MODULE_ALIAS
  2026-01-09  8:31   ` Bartosz Golaszewski
@ 2026-01-09 11:30     ` Jose Javier Rodriguez Barbarin
  0 siblings, 0 replies; 5+ messages in thread
From: Jose Javier Rodriguez Barbarin @ 2026-01-09 11:30 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: linusw, andriy.shevchenko, dev-jorge.sanjuangarcia, linux-gpio,
	linux-kernel

On Fri, Jan 09, 2026 at 09:31:30AM +0100, Bartosz Golaszewski wrote:
> On Thu, Jan 8, 2026 at 2:49 PM Jose Javier Rodriguez Barbarin
> <dev-josejavier.rodriguez@duagon.com> wrote:
> >
> > Since commit 1f4ea4838b13 ("mcb: Add missing modpost build support")
> > the MODULE_ALIAS() is redundant as the module alias is now
> > automatically generated from the MODULE_DEVICE_TABLE().
> >
> > Remove the explicit alias.
> >
> > No functional change intended.
> >
> > Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
> > Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
> > ---
> 
> And what are the changes vs v1?

Hi Bartosz,

Thank you for your answer.

There is no changes in the code between v1 and v2. As I wrote in the cover
letter, the change for v2 is basically the commit renaming.

I know sending v2 without changes is not strictly correct but I decided to do that
because I make some mistakes the first time and I would like to clarify that. 

I failed in first patch series submission as not all people involved received the
cover letter (among other mistakes) so I decided to send each patch as v2
(with its cover letter) to the correct people and mailing lists.

> 
> Bart
> 
> >  drivers/gpio/gpio-menz127.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpio/gpio-menz127.c b/drivers/gpio/gpio-menz127.c
> > index 52b13c6ae496..f51e7517f551 100644
> > --- a/drivers/gpio/gpio-menz127.c
> > +++ b/drivers/gpio/gpio-menz127.c
> > @@ -223,5 +223,4 @@ module_mcb_driver(men_z127_driver);
> >  MODULE_AUTHOR("Andreas Werner <andreas.werner@men.de>");
> >  MODULE_DESCRIPTION("MEN GPIO Controller");
> >  MODULE_LICENSE("GPL v2");
> > -MODULE_ALIAS("mcb:16z127");
> >  MODULE_IMPORT_NS("MCB");
> > --
> > 2.52.0

Regards,

Javier R.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 0/1] gpio: Remove MODULE_ALIAS from gpio-menz127
  2026-01-08 13:48 [PATCH v2 0/1] gpio: Remove MODULE_ALIAS from gpio-menz127 Jose Javier Rodriguez Barbarin
  2026-01-08 13:48 ` [PATCH v2 1/1] gpio: gpio-menz127: drop unneeded MODULE_ALIAS Jose Javier Rodriguez Barbarin
@ 2026-01-12 10:40 ` Bartosz Golaszewski
  1 sibling, 0 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2026-01-12 10:40 UTC (permalink / raw)
  To: linusw, brgl, Jose Javier Rodriguez Barbarin
  Cc: Bartosz Golaszewski, andriy.shevchenko, dev-jorge.sanjuangarcia,
	linux-gpio, linux-kernel


On Thu, 08 Jan 2026 14:48:42 +0100, Jose Javier Rodriguez Barbarin wrote:
> The first patches I sent for fixing the autoload problem encountered
> on mcb device drivers were 2. The first [1] was focused on updating the
> modpost process for letting kbuild to access to the data within
> MODULE_DEVICE_TABLE and the second one [2] for removing the MODULE_ALIAS
> on all mcb client drivers.
> 
> They were rejected and Andy suggested me to split the second patch
> in a per-driver basis instead of sending all drivers' changes in a
> single patch once the first patch was merged.
> 
> [...]

Subject should be: "gpio: menz127: ...", I fixed it when applying.

[1/1] gpio: gpio-menz127: drop unneeded MODULE_ALIAS
      commit: a88d9589125a4d2d1cc2e0e6ba794be30f4de44f

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-01-12 10:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-08 13:48 [PATCH v2 0/1] gpio: Remove MODULE_ALIAS from gpio-menz127 Jose Javier Rodriguez Barbarin
2026-01-08 13:48 ` [PATCH v2 1/1] gpio: gpio-menz127: drop unneeded MODULE_ALIAS Jose Javier Rodriguez Barbarin
2026-01-09  8:31   ` Bartosz Golaszewski
2026-01-09 11:30     ` Jose Javier Rodriguez Barbarin
2026-01-12 10:40 ` [PATCH v2 0/1] gpio: Remove MODULE_ALIAS from gpio-menz127 Bartosz Golaszewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox