From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Xuewen Yan <xuewen.yan@unisoc.com>,
linusw@kernel.org, orsonzhai@gmail.com,
baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com,
clrkwllms@kernel.org, rostedt@goodmis.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rt-devel@lists.linux.dev, ke.wang@unisoc.com,
wenhua.lin@unisoc.com, xuewen.yan94@gmail.com
Subject: Re: [PATCH] gpio: sprd: Change sprd_gpio lock to raw_spin_lock
Date: Tue, 27 Jan 2026 20:36:16 +0100 [thread overview]
Message-ID: <aXkTsMqZ4iZyVM0J@black.igk.intel.com> (raw)
In-Reply-To: <CAMRc=Md+ptvRvknV7C4g2W_vpkfQmLkanKUqXzM8eYSe5ns1dQ@mail.gmail.com>
On Tue, Jan 27, 2026 at 10:07:01AM +0100, Bartosz Golaszewski wrote:
> On Mon, Jan 26, 2026 at 10:50 AM Sebastian Andrzej Siewior
> <bigeasy@linutronix.de> wrote:
> > On 2026-01-26 17:42:09 [+0800], Xuewen Yan wrote:
...
> > > There was a lockdep warning in sprd_gpio:
> > > [ 6.258411][T329@C6] el0t_64_sync+0x1c4/0x1c8
> >
> > This could be reduced to "BUG: Invalid wait context". The other bits
> > provide to added value.
> >
> > > This is because the spin_lock would change to rt_mutex in PREEMPT_RT,
> > > however the sprd_gpio->lock would use in hard-irq, this is unsafe.
> > >
> > > So change the spin_lock to raw_spin_lock to use the spinlock
> >
> > spinlock_t to raw_spinlock_t
>
> I fixed this in git.
Not sure if you noticed the above comment by Sebastian and it's actually
documented in Submitting Patches that backtraces should only carry the
necessary information, so usually ~3-5 lines is enough and not two full pages
like in the commit as I see in the repository.
> Bart
>
> > > in hard-irq.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-27 19:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 9:42 [PATCH] gpio: sprd: Change sprd_gpio lock to raw_spin_lock Xuewen Yan
2026-01-26 9:50 ` Sebastian Andrzej Siewior
2026-01-27 9:07 ` Bartosz Golaszewski
2026-01-27 19:36 ` Andy Shevchenko [this message]
2026-01-28 9:10 ` Bartosz Golaszewski
2026-01-26 9:52 ` Baolin Wang
2026-01-27 9:09 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXkTsMqZ4iZyVM0J@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bigeasy@linutronix.de \
--cc=brgl@kernel.org \
--cc=clrkwllms@kernel.org \
--cc=ke.wang@unisoc.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=orsonzhai@gmail.com \
--cc=rostedt@goodmis.org \
--cc=wenhua.lin@unisoc.com \
--cc=xuewen.yan94@gmail.com \
--cc=xuewen.yan@unisoc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox