* [PATCH v1 1/1] pinctrl: tangier: Remove duplicate error messages
@ 2026-01-28 12:45 Andy Shevchenko
2026-01-28 13:18 ` Mika Westerberg
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2026-01-28 12:45 UTC (permalink / raw)
To: Andy Shevchenko, linux-kernel, linux-gpio
Cc: Andy Shevchenko, Mika Westerberg, Linus Walleij
The pin control core is covered to report any error via message.
Since that it's not needed in the callers.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-tangier.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/intel/pinctrl-tangier.c b/drivers/pinctrl/intel/pinctrl-tangier.c
index 44b333d6c7cb..e1af1ddfc951 100644
--- a/drivers/pinctrl/intel/pinctrl-tangier.c
+++ b/drivers/pinctrl/intel/pinctrl-tangier.c
@@ -566,7 +566,7 @@ int devm_tng_pinctrl_probe(struct platform_device *pdev)
tp->pctldev = devm_pinctrl_register(dev, &tp->pctldesc, tp);
if (IS_ERR(tp->pctldev))
- return dev_err_probe(dev, PTR_ERR(tp->pctldev), "failed to register pinctrl\n");
+ return PTR_ERR(tp->pctldev);
return 0;
}
--
2.50.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: tangier: Remove duplicate error messages
2026-01-28 12:45 [PATCH v1 1/1] pinctrl: tangier: Remove duplicate error messages Andy Shevchenko
@ 2026-01-28 13:18 ` Mika Westerberg
2026-01-28 13:29 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Mika Westerberg @ 2026-01-28 13:18 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-kernel, linux-gpio, Andy Shevchenko, Linus Walleij
On Wed, Jan 28, 2026 at 01:45:06PM +0100, Andy Shevchenko wrote:
> The pin control core is covered to report any error via message.
> Since that it's not needed in the callers.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: tangier: Remove duplicate error messages
2026-01-28 13:18 ` Mika Westerberg
@ 2026-01-28 13:29 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2026-01-28 13:29 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-kernel, linux-gpio, Andy Shevchenko, Linus Walleij
On Wed, Jan 28, 2026 at 02:18:13PM +0100, Mika Westerberg wrote:
> On Wed, Jan 28, 2026 at 01:45:06PM +0100, Andy Shevchenko wrote:
> > The pin control core is covered to report any error via message.
> > Since that it's not needed in the callers.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-28 13:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-28 12:45 [PATCH v1 1/1] pinctrl: tangier: Remove duplicate error messages Andy Shevchenko
2026-01-28 13:18 ` Mika Westerberg
2026-01-28 13:29 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox