public inbox for linux-gpio@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: 434779359@qq.com, "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Linus Walleij" <linusw@kernel.org>,
	"Bartosz Golaszewski" <brgl@kernel.org>,
	liufulin <frank.liu@faiot.com>,
	"Waqar Hameed" <waqar.hameed@axis.com>,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH] tof: Add VL53L4CX TOF drivers
Date: Sat, 14 Feb 2026 20:19:50 +0200	[thread overview]
Message-ID: <aZC8xn2jzZYEefIr@smile.fi.intel.com> (raw)
In-Reply-To: <20260214162526.01e1e336@jic23-huawei>

On Sat, Feb 14, 2026 at 04:25:26PM +0000, Jonathan Cameron wrote:
> On Sun, 8 Feb 2026 15:13:23 +0200
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> > On Sat, Feb 07, 2026 at 01:49:50PM +0000, Jonathan Cameron wrote:
> > > On Sat,  7 Feb 2026 17:42:35 +0800
> > > 434779359@qq.com wrote:  

...

> > Yeah, this is even barely satisfies requirement to put into staging/iio.
> 
> Just to cut off any chance of wrong interpretation: We don't put new devices
> through staging/iio any more.  There is little reason to do so now that the core
> is out of there and mass refactors and ABI changes are a thing of the distant
> past.
> 
> Now it's much swifter to clean a driver up on list.
> 
> Maybe there is a reason we might consider drivers/staging again for IIO
> device drivers, but I've not thought of it yet!

Depends on the quality of the driver and eagerness to have it in the kernel.

> > It has so-o-o many style issues and other small things (I just pressed PgDn
> > several times within 5 seconds). You need to take your time and invest into:
> > - creating an upstream plan (roadmap)
> > - as Jonathan said, start with a minimalistic setup (not more than a couple of
> >   thousands of LoCs
> > - be sure the style follows the Coding Style and IIO subsystem specifics
> > - be sure the code uses modern APIs from kernel and not some outdated stuff

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-02-14 18:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-07  9:42 [PATCH] tof: Add VL53L4CX TOF drivers 434779359
2026-02-07 13:49 ` Jonathan Cameron
2026-02-07 21:41   ` Linus Walleij
2026-02-08 13:13   ` Andy Shevchenko
2026-02-14 16:25     ` Jonathan Cameron
2026-02-14 18:19       ` Andy Shevchenko [this message]
2026-02-07 17:13 ` kernel test robot
2026-02-08  2:19 ` kernel test robot
2026-02-08 17:00 ` Waqar Hameed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZC8xn2jzZYEefIr@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=434779359@qq.com \
    --cc=andy@kernel.org \
    --cc=brgl@kernel.org \
    --cc=broonie@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=frank.liu@faiot.com \
    --cc=jic23@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=waqar.hameed@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox