From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 805F7337BB0; Mon, 23 Feb 2026 17:59:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771869555; cv=none; b=pfDRctDZhyXE2Kq0xCXtF4c94bbPBJIFbO3vcsdSCHyy/oihwagicXs72JZu+C+a3EM3SeL644XwXBNsp4yCVsZujIPOrQaatwTq++HQcYb8UPswmWnsf0lb74zSKFTa9FS2pKFkzg1xabp4sHHZs/Z3cXL9Uo+tWR9Cl1GpPlk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771869555; c=relaxed/simple; bh=ITWecORPFgm3sy7YlYtSuVygImsM/yQTFUyOt2gzHVc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aYyv9Ff+NtgcChXyCxsqh/hL/8+QHCHj4EP2WfTpTHpAIFjZ9ODPtXO7Ha5jz/SQ9vHW7IyHd1EOdaxNazyekb+eYvah6ZnfLsweus1O7gEK/PyWicXphX01i9yo9vlSkwwvReD4/UQFbBN7A2vVDvySe/tRjiUPkJPRi76kjso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hCEm+SFp; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hCEm+SFp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771869554; x=1803405554; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ITWecORPFgm3sy7YlYtSuVygImsM/yQTFUyOt2gzHVc=; b=hCEm+SFpPCX/EdQyysmk0IMuhvFSDdU/Mba5fC26mnbfmbks08Dm+gfz 789YBE/TRW6ZS3YKZ7jVg/BbNcgSVgohlGXWsIhmYEsRogIjwdB9FsqGh sD+cxs0QRwp3BN6RPIbSz9wJD98okEsSs27Upg5cG3GYcQPZyymK0UT4R Q+Qr28rUPKLS91KXxveC3QFzTI+wa8HCDdBgZ8NU+Hu26P7UIpkJcrwzB nNBoWWd8ol/9BpQkjQMWXbWYhtEQaxnHc2RlhuWJ0gCOzgeGqvPY7e05g Q2S3jHGD8YRRJh9a3PIBeP2gV0jfMLi/yv8Uu7iF7IKlfPKgj/dJD74nU Q==; X-CSE-ConnectionGUID: g67rRxkPT/uLI+jbtgpyaw== X-CSE-MsgGUID: BEIFGo4dQKmCZ+bsqD2AHg== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="98336244" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="98336244" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 09:59:14 -0800 X-CSE-ConnectionGUID: uGbkj7fRSXiiayaehKB0Ew== X-CSE-MsgGUID: MAR5ivknT62NtPUWrzw6Kg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="220636549" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.245.222]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 09:59:13 -0800 Date: Mon, 23 Feb 2026 19:59:10 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpio: introduce a header for symbols shared by suppliers and consumers Message-ID: References: <20260223172006.204268-1-bartosz.golaszewski@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260223172006.204268-1-bartosz.golaszewski@oss.qualcomm.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Feb 23, 2026 at 06:20:06PM +0100, Bartosz Golaszewski wrote: > GPIO_LINE_DIRECTION_IN/OUT definitions are used both in supplier (GPIO > controller drivers) as well as consumer code. In order to not force the > consumers to include gpio/driver.h or - even worse - to redefine these > values, create a new header file - gpio/defs.h - and move them over > there. Include this header from both gpio/consumer.h and gpio/driver.h. It was discussed before off the list, but I agree with the direction it goes. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko > Signed-off-by: Bartosz Golaszewski > --- > Andy, Linus: I'm no longer sure who proposed it but I've had it on my > TODO list. Please feel free to take credit below. I believe both, I added mine above. -- With Best Regards, Andy Shevchenko