From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linusw@kernel.org>
Subject: Re: [PATCH v1 1/1] gpio: generic: Don't use 'proxy' headers
Date: Thu, 26 Feb 2026 11:31:22 +0200 [thread overview]
Message-ID: <aaAS6vdnLzD3zP1g@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=McM+Adk7fVp0jpWUvRQSa=Q3BK8BRC24RXoB0ussbsRww@mail.gmail.com>
On Thu, Feb 26, 2026 at 10:24:59AM +0100, Bartosz Golaszewski wrote:
> On Thu, Feb 26, 2026 at 10:20 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
...
> > #include <linux/bitops.h>
> > #include <linux/cleanup.h>
> > -#include <linux/compiler.h>
> > #include <linux/err.h>
> > -#include <linux/init.h>
> > #include <linux/io.h>
> > #include <linux/ioport.h>
> > +#include <linux/limits.h>
> > #include <linux/log2.h>
> > #include <linux/mod_devicetable.h>
> > #include <linux/module.h>
> > #include <linux/pinctrl/consumer.h>
> > #include <linux/platform_device.h>
> > #include <linux/property.h>
> > -#include <linux/slab.h>
>
> In that case don't we need device.h for devm_kzalloc()?
(It is device/devres.h, but read below)
It comes thru platform_device.h. And if you follow my attempts to split
device.h, the state of affairs will look like not much will happen there,
so the platform_device.h <- device.h <- devres/device.h is guaranteed.
TL;DR: if we have platform_device.h, it covers everything that device.h
provides.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-26 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 9:20 [PATCH v1 1/1] gpio: generic: Don't use 'proxy' headers Andy Shevchenko
2026-02-26 9:24 ` Bartosz Golaszewski
2026-02-26 9:31 ` Andy Shevchenko [this message]
2026-02-26 22:01 ` Linus Walleij
2026-02-27 8:58 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaAS6vdnLzD3zP1g@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox