From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Linus Walleij <linusw@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
Peter Rosin <peda@axentia.se>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-gpio@vger.kernel.org, David Jander <david@protonic.nl>
Subject: Re: [PATCH v1 3/8] dt-bindings: pinctrl: add NXP MC33978/MC34978 pinctrl
Date: Fri, 27 Feb 2026 11:41:08 +0100 [thread overview]
Message-ID: <aaF0xNKzz74h0gBA@pengutronix.de> (raw)
In-Reply-To: <CAD++jL=PKnAa6CrzGOwPoS_kJJjiHEvztgAFdEoYpHDPj6WT9Q@mail.gmail.com>
On Fri, Feb 27, 2026 at 12:02:53AM +0100, Linus Walleij wrote:
> On Fri, Feb 27, 2026 at 12:00 AM Linus Walleij <linusw@kernel.org> wrote:
> > On Wed, Feb 25, 2026 at 6:16 PM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
>
> > > + - Pins 14-21: SP0-SP7 (Programmable inputs, can be SG or SB)
> >
> > What is SB now? Please explain :)
> Oh I see in the driver that this is Switch-to-battery. So document that here
> in the bindings too.
>
> Also it seems that something configured as switch-to-batter must be
> flagged GPIO_ACTIVE_HIGH.
Actually, the active polarity depends entirely on the external circuit,
especially since these pins can also be used as controllable current
outputs.
For example, we attach LEDs directly to the pins. If an LED is
attached to an SG pin (or an SP pin operating in SG mode), the pin sinks
current to ground to turn the LED on, making it GPIO_ACTIVE_HIGH from
the LED consumer's perspective.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2026-02-27 10:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 17:15 [PATCH v1 0/8] mfd: Add support for NXP MC33978/MC34978 MSDI Oleksij Rempel
2026-02-25 17:15 ` [PATCH v1 1/8] dt-bindings: mfd: add " Oleksij Rempel
2026-02-26 8:16 ` Krzysztof Kozlowski
2026-02-25 17:15 ` [PATCH v1 2/8] mfd: add NXP MC33978/MC34978 core driver Oleksij Rempel
2026-02-25 17:15 ` [PATCH v1 3/8] dt-bindings: pinctrl: add NXP MC33978/MC34978 pinctrl Oleksij Rempel
2026-02-26 23:00 ` Linus Walleij
2026-02-26 23:02 ` Linus Walleij
2026-02-27 10:41 ` Oleksij Rempel [this message]
2026-02-27 14:06 ` Linus Walleij
2026-02-27 10:04 ` Oleksij Rempel
2026-02-25 17:15 ` [PATCH v1 4/8] pinctrl: add NXP MC33978/MC34978 pinctrl driver Oleksij Rempel
2026-02-26 23:40 ` Linus Walleij
2026-02-27 10:58 ` Oleksij Rempel
2026-02-27 14:08 ` Linus Walleij
2026-02-25 17:15 ` [PATCH v1 5/8] dt-bindings: hwmon: add NXP MC33978/MC34978 hwmon Oleksij Rempel
2026-02-26 8:17 ` Krzysztof Kozlowski
2026-02-25 17:15 ` [PATCH v1 6/8] hwmon: add NXP MC33978/MC34978 driver Oleksij Rempel
2026-02-25 17:15 ` [PATCH v1 7/8] dt-bindings: mux: add NXP MC33978/MC34978 AMUX Oleksij Rempel
2026-02-26 8:14 ` Krzysztof Kozlowski
2026-02-25 17:15 ` [PATCH v1 8/8] mux: add NXP MC33978/MC34978 AMUX driver Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaF0xNKzz74h0gBA@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=conor+dt@kernel.org \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox