From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99573392818; Fri, 20 Mar 2026 10:38:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774003105; cv=none; b=QWal0cD0HTN+uR4oYmnmxzvUW0U5DLbl9DcHCYq68lBnuMeSbc+Bi00E2TLz/RpGKdlF/lv7H1jaxLrt+21/IGXhqgmGvUWqhfGv5uvN++8niMRydHTYVUVml7kRxpZ8j84SZjK8JEMAuTq5TqItPiKat0Zu+xj/sxHXZjmMGBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774003105; c=relaxed/simple; bh=gMVGMwrvlhSKPLhRN0bux7/s5qAGHCFJcmzPq35TBOM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tVF8ckxioFNRsHyvrKwZo6y4nWwOOGPUScwREArKMnhjcKA7xU+zCs86jspD3Vy8v3yKgqYfRRzuxpjj9nKQ//iaghLgI5ilVy/6ywAMSIdoYn5EsFP7OVUq//ile92nih5koPw5R1pqN6nkygrPXzI0KfBLEzeq95x0T4ZeQQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gaVsxeTc; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gaVsxeTc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774003105; x=1805539105; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=gMVGMwrvlhSKPLhRN0bux7/s5qAGHCFJcmzPq35TBOM=; b=gaVsxeTcI4gOqRQvw0OR+QN0DxknifaNFsvTjUCqkr0+nWBTafJTOrnh 0CmTaC38W8zL60rRZWwrhkm3Ghkpn5RlmbQ4Smj84lqZ5QvtWP8c1R8WY qteU8pbw8YYYhSBLNdH9dU6XYH7dAuJUPp++MSfu5IFLa4IKwbBBc9Lkr /hUFhhWGxWljPKg4tN6liMTpt5JXakonwtko3oitnsik/+9S1afJNpIjt 7q3QfDAfQPeEBpjhB7Ixp4zvyjJi3LjRrkCoMCOXdUIjwylo2xH1MrmBo EvDMPLEJdNec5ZJQIJhVNI79XAhLnateo91QCvl+vh2WgzTJQbvxOuVq7 Q==; X-CSE-ConnectionGUID: 9O5utjD+S6ytPXrKh9UV2A== X-CSE-MsgGUID: WbTbvSs7Sbej+mOE6wHNsw== X-IronPort-AV: E=McAfee;i="6800,10657,11734"; a="74787670" X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="74787670" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2026 03:38:25 -0700 X-CSE-ConnectionGUID: nOj8Pb9xSimgluByhTgAaQ== X-CSE-MsgGUID: W29P3dsLQsC6aEYwKrROaw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="223275845" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.245.40]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2026 03:38:20 -0700 Date: Fri, 20 Mar 2026 12:38:17 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Mika Westerberg , Andy Shevchenko , Linus Walleij , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Dmitry Torokhov , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 2/4] pinctrl: intel: expose software nodes for baytrail GPIO devices Message-ID: References: <20260319-baytrail-real-swnode-v1-0-75f2264ae49f@oss.qualcomm.com> <20260319-baytrail-real-swnode-v1-2-75f2264ae49f@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260319-baytrail-real-swnode-v1-2-75f2264ae49f@oss.qualcomm.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Mar 19, 2026 at 05:10:55PM +0100, Bartosz Golaszewski wrote: > Use the new automatic secondary fwnode API to ensure that when the > baytrail pinctrl device is added to the platform bus, the static > software node provided for drivers not able to use ACPI will get > automatically assigned as the secondary fwnode of the primary ACPI node. > > Create a new header under linux/pinctrl/ containing intel-specific > symbols and declare the new variables there. As I read the code, this doesn't need to be part of drivers/pinctrl/intel/. I.o.w. I am unable to see why we need to penetrate the certain pinctrl driver for this. ... > static int __init byt_gpio_init(void) > { > - return platform_driver_register(&byt_gpio_driver); > + int ret; > + > + ret = software_node_register_auto_secondary(&byt_auto_secondary); > + if (ret) > + return ret; > + > + ret = platform_driver_register(&byt_gpio_driver); > + if (ret) > + software_node_unregister_auto_secondary(&byt_auto_secondary); > + > + return ret; > } This hack can be done in similar way on how we do ACPI LPSS for those platforms, i.e. in drivers/acpi/x86/lpss.c. No? -- With Best Regards, Andy Shevchenko