From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: Lee Jones <lee@kernel.org>, Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 2/3] gpio: timberdale: use device properties
Date: Fri, 13 Mar 2026 12:24:11 +0200 [thread overview]
Message-ID: <abPly5ZYd1M_HD5V@ashevche-desk.local> (raw)
In-Reply-To: <abPlPQMPZyOL_byn@ashevche-desk.local>
On Fri, Mar 13, 2026 at 12:21:54PM +0200, Andy Shevchenko wrote:
> On Fri, Mar 13, 2026 at 11:04:49AM +0100, Bartosz Golaszewski wrote:
...
> Shouldn't this be done in the respective callbacks before the
> devm_gpiochip_add_data() finishes? (Yes, it's not related to this
> patch, but it is related to seems racy driver initialisation.
And with that being said, wouldn't be better to move the driver to one
of the generic library (gpio-regmap / gpio-mmio)?
Also it mentions FPGA in the header, I am wondering what that FPGA is.
Perhaps we have already similar driver in the kernel from the FPGA vendor?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-13 10:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 10:04 [PATCH 0/3] gpio: timberdale: remove platform data header Bartosz Golaszewski
2026-03-13 10:04 ` [PATCH 1/3] mfd: timberdale: set up a software node for the GPIO cell Bartosz Golaszewski
2026-03-13 10:04 ` [PATCH 2/3] gpio: timberdale: use device properties Bartosz Golaszewski
2026-03-13 10:21 ` Andy Shevchenko
2026-03-13 10:24 ` Andy Shevchenko [this message]
2026-03-13 13:27 ` Bartosz Golaszewski
2026-03-13 14:08 ` Andy Shevchenko
2026-03-16 13:58 ` Linus Walleij
2026-03-13 10:04 ` [PATCH 3/3] gpio: timberdale: remove platform data header Bartosz Golaszewski
2026-03-13 10:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abPly5ZYd1M_HD5V@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox