From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 156FB4A014E for ; Tue, 8 Sep 2026 13:27:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788874078; cv=none; b=fRFGN6RruNZ4rgxpMj7iiOUC2DhA5p+Bg3LVqdvCau1rUK8gHLG2ooXB83k/1XkRW5ETO5lstbYz3+WRly768ejvsgDoglDGtXkIEmuMmeX6QjOAOOJtC+4+Mzq8FJOBYGCVdMAyWcDMyFhj6Wn9YPqdL2ZIR4fWWc5uw1O2bbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788874078; c=relaxed/simple; bh=RQ4g8roiCImK09lGOGkJ6W+2Czo4bfLHxiAgB+DarvI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tSqtNhbQh4Zjhf0iYjnkPF7F+yO9HpD4xI6JPKdLhZcJc/vWgybvFn9sBTd+srD8Cu527mAE7o1AAky7uZJk/dp9Nk9gWblmef24LJglQuw/ukhGZ4DRQ1GGUzwpKsWZW44Kgowk8gqZ2ByzPIU4eihDYr0EVkqjtbzFj4YNp44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=VaGeVBMV; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="VaGeVBMV" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-92f0b5ed131so554167985a.3 for ; Tue, 08 Sep 2026 06:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1788874061; x=1789478861; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ljmgwCAVphhfVW4k+b+cxvt43CtdExVqUZy6qEm1NMU=; b=VaGeVBMVvfcfuopMTbsglQM1RH0UOrRFSPJZT3WtgxfqOgNLandccrc/MO8grDPLMC gbZ5X4Zpj4fiMfEfJL1hAxIXEVuD0HzLyATcZPS2RawGaqFgEheMkzosZlmRvqFn/EMs K+d/SW18cgFjOQ/SLEqRsMXtG4y7+M2cMv6PdDYBypEblr18PWJ9UItFLp/5JMPBydAp TbOYE4drFSxChcCOYgNJqJgP9hdFShpFUsN1SnvF9lyrsOnW8SWdN/GwgqXzlLU1urBY woLzVDVZBYY4adtCFAZn6a1EwtPRO9kVqdSeMUB97t/iapywn8y6auuCEZyAoaudUjbN cyKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788874061; x=1789478861; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ljmgwCAVphhfVW4k+b+cxvt43CtdExVqUZy6qEm1NMU=; b=Ojc2/jERQwVz6VwZeHf/vw6yZL+y8upjdiBShwoLLitgliuEKa/2aO2q8b4e5Q0BCs 8qJ+15tjGqGUcfiFKLuIhVqNjlvU+wMq0bM4V9zxoN01bMekL2ZK5ADGFn71s2j30EFF UlwY3VLkf0A3lsWs5TS2Mrq9a/Y9sawzbVqMR8b0LuYF7o2ePCnioEoY7VU8J2sL1plv kClN1hHNDq3M1jSuQH3Psl1Ldu+KD8Uq54NibLufB9uH6+H9OC1jhesbPeILZdWJ4ajf dvorzRie9jazeL0957a192TGOOtZ6VWviN2DKu7PcdKUU4lLURddbGBzLr3bEVWgCBMU kB6Q== X-Forwarded-Encrypted: i=1; AKwUvBxPWSXPpNOOJr8Mq9YRDyOq21PIk4klYOZnTKFm4wBp/XT+fGKpfJzLbJCbh1wclt8mpLpWTwY3fKh/@vger.kernel.org X-Gm-Message-State: AFuF++kqtHb401S+VhDQhlG4cAvCWlJTl26ObcfZPE3+MoPqzbBUyexX /CIVE71xooVJAvSl1vBPqHJaFCgT7BcS3aeYVz74OH6XSGTgtdGA/aQB4qxvDWwZu8A= X-Gm-Gg: AYBFou0CrCFW74SnLPCRLLB1MvF+7ftE/4GQEuJza9/iNJCDFEu2Q0bsIHBMEIosxOe 2fNS4gsDLVX11eU1pfFtfHtDf22KzraojshmrZmOG4HDIzWQ0yVOR9jr1+1z04OCF4j+ABGHEH4 XJttgeDSQW9ltvdanMiGR7pvTnXo6e0XZ/1QPKjf8bWoEar6bEYdYdoihmD5ncKo+nQqUsaGXBw ho3zMwgjbgjK0iUnbVLbXqvNvM3vmMbCXiro++hCrxAAdHkCGZ7psCCD89/JX4u7FBeKv7e3qYq SyJNJqNbBf48gQg8cV63oCdb+Yoq9bUr6gns2WKOleGDhI+jngzJyE/7XkYRWRBfRp4G2ypZvX/ Nh0YA96jkjpQN+ei69duaK6Pp04+FXFQKR+7Ciu7OgRPPCg5sybyGHgAjT/4JGDF9zILhXfq/AA T0QRLyYjHktshxBFqNHePvZ0Z8P+jObtBu8NQN4bSg6bzl0THJlKXTjKqirwlz X-Received: by 2002:a05:620a:8198:b0:939:5cd3:75ce with SMTP id af79cd13be357-93980311c5bmr2025182085a.8.1788874059680; Tue, 08 Sep 2026 06:27:39 -0700 (PDT) Received: from [172.22.22.28] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id af79cd13be357-939b8fbc1dbsm249492285a.11.2026.09.08.06.27.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Sep 2026 06:27:39 -0700 (PDT) Message-ID: Date: Tue, 8 Sep 2026 08:27:37 -0500 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/5] PCI/pwrctrl: tc9563: introduce support for embedded GPIO controller To: Lorenzo Bianconi , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chaitanya Chundru , Linus Walleij , Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Michael Walle Cc: Daniel Thompson , Sushrut Shree Trivedi , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Bartosz Golaszewski , Manivannan Sadhasivam , Konrad Dybcio , Abel Vesa References: <20260904-pci-tc9563-aux-v3-0-5b1449d62ba2@oss.qualcomm.com> Content-Language: en-US From: Alex Elder In-Reply-To: <20260904-pci-tc9563-aux-v3-0-5b1449d62ba2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/4/26 12:15 PM, Lorenzo Bianconi wrote: > This series is based on pwrctrl upstream branch. I'm accustomed to a cover page that's a bit more informative than this about the subject of the series overall. Your use of --base (to produce the "base-commit" tag below) duplicates (more specifically) the above statement anyway. How about just a little bit of context about how the TC9563 uses an embedded GPIO controller that we now wish to also use in another driver. So this series isolates the access to that IP block in a separate driver that can safely share access? You might even highlight that the TC9563 is an SoC that *contains* a PCIe switch, but also contains other components (including an I2C interface and GPIO controller). Aside from that, the series looks good to me. You just need approval from the devicetree maintainers. -Alex > --- > Changes in v3: > - Describe gpio-controller support in TC9563 binding instead of defining > a gpio child node. > - Link to v2: https://lore.kernel.org/r/20260903-pci-tc9563-aux-v2-0-34c625b542c1@oss.qualcomm.com > > Changes in v2: > - Fix PCI_PWRCTRL_TC9563 Kconfig dependency > - Move of_node refcounting management in tc9563_pwrctrl_adev_add(). > - Link to v1: https://lore.kernel.org/r/20260901-pci-tc9563-aux-v1-0-dd9b80738e70@oss.qualcomm.com > > --- > Alex Elder (1): > gpio: tc9563: Add support for the embedded GPIO controller > > Lorenzo Bianconi (4): > dt-bindings: PCI: toshiba,tc9563: Document embedded GPIO controller > PCI/pwrctrl: tc9563: Add GPIO auxiliary device support > PCI/pwrctrl: tc9563: Switch per-port reset to GPIO descriptor API > arm64: dts: qcom: qcs6490-rb3gen2: Enable TC9563 embedded GPIO controller > > .../devicetree/bindings/pci/toshiba,tc9563.yaml | 19 ++- > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 7 +- > drivers/gpio/Kconfig | 11 ++ > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-tc9563.c | 99 +++++++++++++ > drivers/pci/pwrctrl/Kconfig | 1 + > drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 154 +++++++++++++++++++-- > include/linux/soc/qcom/tc9563.h | 19 +++ > 8 files changed, 294 insertions(+), 17 deletions(-) > --- > base-commit: 028f86457e822ab9de5b0d6d23efddc1b8b54ae1 > change-id: 20260731-pci-tc9563-aux-66a29d438f60 > > Best regards,