From: Dan Carpenter <dan.carpenter@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Peng Fan <peng.fan@oss.nxp.com>, Tom Rini <trini@konsulko.com>,
AKASHI Takahiro <akashi.tkhro@gmail.com>,
Peng Fan <peng.fan@nxp.com>, Greg Malysa <malysagreg@gmail.com>,
Utsav Agarwal <utsav.agarwal@analog.com>,
Vasileios Bimpikas <vasileios.bimpikas@analog.com>,
Ian Roberts <ian.roberts@timesys.com>,
Oliver Gaskell <Oliver.Gaskell@analog.com>,
Yegor Yefremov <yegorslists@googlemail.com>,
Philip Molloy <philip.molloy@analog.com>,
Nathan Barrett-Morrison <nathan.morrison@timesys.com>,
Eoin Dickson <eoin.dickson@microchip.com>,
Arturs Artamonovs <arturs.artamonovs@analog.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Tanmay Kathpalia <tanmay.kathpalia@altera.com>,
u-boot@lists.denx.de, Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
arm-scmi@vger.kernel.org, linux-gpio@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Khaled Ali Ahmed <Khaled.AliAhmed@arm.com>,
Michal Simek <michal.simek@amd.com>
Subject: Re: [PATCH v2 4/4] gpio: scmi: Add gpio_scmi driver
Date: Tue, 24 Mar 2026 14:40:38 +0300 [thread overview]
Message-ID: <acJ4NiwCRchgq7-t@stanley.mountain> (raw)
In-Reply-To: <acDzsKoMdfcXecca@ashevche-desk.local>
On Mon, Mar 23, 2026 at 10:02:56AM +0200, Andy Shevchenko wrote:
> On Mon, Mar 23, 2026 at 11:41:49AM +0800, Peng Fan wrote:
>
> [....]
>
> > >+ ret = snprintf(NULL, 0, "gpio_scmi%d_", bank_cnt);
> > >+ uc_priv->bank_name = devm_kzalloc(dev, ret + 1, GFP_KERNEL);
> > >+ if (!uc_priv->bank_name)
> > >+ return -ENOMEM;
> > >+ snprintf(uc_priv->bank_name, ret + 1, "gpio_scmi%d_", bank_cnt);
> >
> > build fail in CI [1]:
>
> Moreover, this is reinvention of devm_kasprintf() to begin with.
>
devm_kasprintf() isn't an option in u-boot.
regards,
dan carpenter
next prev parent reply other threads:[~2026-03-24 11:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 19:39 [PATCH v2 0/4] u-boot: add SCMI GPIO/Pinctrl support Dan Carpenter
2026-03-11 19:41 ` [PATCH v2 3/4] scmi: pinctrl: add pinctrl driver for SCMI Dan Carpenter
2026-03-12 9:23 ` Peng Fan
2026-03-24 13:19 ` Linus Walleij
2026-03-24 15:07 ` Dan Carpenter
2026-03-26 9:30 ` Dan Carpenter
2026-03-11 19:41 ` [PATCH v2 4/4] gpio: scmi: Add gpio_scmi driver Dan Carpenter
2026-03-17 9:05 ` Peng Fan
2026-03-23 3:41 ` Peng Fan
2026-03-23 8:02 ` Andy Shevchenko
2026-03-24 11:40 ` Dan Carpenter [this message]
2026-03-24 11:53 ` Andy Shevchenko
2026-03-23 6:20 ` [PATCH v2 0/4] u-boot: add SCMI GPIO/Pinctrl support Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acJ4NiwCRchgq7-t@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=Khaled.AliAhmed@arm.com \
--cc=Oliver.Gaskell@analog.com \
--cc=akashi.tkhro@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=arm-scmi@vger.kernel.org \
--cc=arturs.artamonovs@analog.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=eoin.dickson@microchip.com \
--cc=ian.roberts@timesys.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=malysagreg@gmail.com \
--cc=michal.simek@amd.com \
--cc=nathan.morrison@timesys.com \
--cc=neil.armstrong@linaro.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=philip.molloy@analog.com \
--cc=tanmay.kathpalia@altera.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=utsav.agarwal@analog.com \
--cc=vasileios.bimpikas@analog.com \
--cc=vincent.guittot@linaro.org \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox