linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pinctrl: palmas: Delete an error message for a failed memory allocation in palmas_pinctrl_probe()
@ 2017-12-23 20:30 SF Markus Elfring
  2018-01-02  8:45 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2017-12-23 20:30 UTC (permalink / raw)
  To: linux-gpio, Laxman Dewangan, Lee Jones, Linus Walleij,
	Stephen Warren
  Cc: LKML, kernel-janitors

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 23 Dec 2017 21:16:42 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/pinctrl/pinctrl-palmas.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-palmas.c b/drivers/pinctrl/pinctrl-palmas.c
index 4d6a5015b927..d42f18cb1bc7 100644
--- a/drivers/pinctrl/pinctrl-palmas.c
+++ b/drivers/pinctrl/pinctrl-palmas.c
@@ -1012,10 +1012,8 @@ static int palmas_pinctrl_probe(struct platform_device *pdev)
 	}
 
 	pci = devm_kzalloc(&pdev->dev, sizeof(*pci), GFP_KERNEL);
-	if (!pci) {
-		dev_err(&pdev->dev, "Malloc for pci failed\n");
+	if (!pci)
 		return -ENOMEM;
-	}
 
 	pci->dev = &pdev->dev;
 	pci->palmas = dev_get_drvdata(pdev->dev.parent);
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] pinctrl: palmas: Delete an error message for a failed memory allocation in palmas_pinctrl_probe()
  2017-12-23 20:30 [PATCH] pinctrl: palmas: Delete an error message for a failed memory allocation in palmas_pinctrl_probe() SF Markus Elfring
@ 2018-01-02  8:45 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2018-01-02  8:45 UTC (permalink / raw)
  To: SF Markus Elfring
  Cc: linux-gpio, Laxman Dewangan, Lee Jones, Stephen Warren, LKML,
	kernel-janitors

On Sat, Dec 23, 2017 at 9:30 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 23 Dec 2017 21:16:42 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-02  8:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-23 20:30 [PATCH] pinctrl: palmas: Delete an error message for a failed memory allocation in palmas_pinctrl_probe() SF Markus Elfring
2018-01-02  8:45 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).