From: Mark Brown <broonie@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: uda1380: Modernize the driver
Date: Thu, 9 Apr 2026 20:32:06 +0100 [thread overview]
Message-ID: <adf-tmIfkLgosjRJ@sirena.co.uk> (raw)
In-Reply-To: <20260409-asoc-uda1380-v2-1-42d02079ecd5@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
On Thu, Apr 09, 2026 at 09:17:14PM +0200, Linus Walleij wrote:
> This makes the driver usable on contemporary Linux, maybe it will
> even work, I can't test it.
Don't think so...
> @@ -742,6 +745,7 @@ static const struct snd_soc_component_driver soc_component_dev_uda1380 = {
> static int uda1380_i2c_probe(struct i2c_client *i2c)
> {
> struct uda1380_platform_data *pdata = i2c->dev.platform_data;
> + struct device *dev = &i2c->dev;
> struct uda1380_priv *uda1380;
> int ret;
We still have the platform data above, and just below this we have:
if (!pdata)
return -EINVAL;
so I'm not sure how the driver is going to instantiate, there's
mandatory platform data still. Not that the driver would've
instantiated before either with anyhing in mainline...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-04-09 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 19:17 [PATCH v2] ASoC: uda1380: Modernize the driver Linus Walleij
2026-04-09 19:32 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adf-tmIfkLgosjRJ@sirena.co.uk \
--to=broonie@kernel.org \
--cc=brgl@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox