From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EC083002DC; Thu, 9 Apr 2026 19:38:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775763537; cv=none; b=gvejguYZhyjt3IfoDJtc5mtm31qoI1kH1yjdkGIUFNriPS8MpBfA1gHcKTpR+tWboprNie6wgIRdCSCKEEoaRlm7nKlXqOofm//MgeGaACVDHJBH5xvnQeurU424R20wj5q0cU2pFEKagh7MfUnnJHcRxY0+AkzXgISCF13Y+eY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775763537; c=relaxed/simple; bh=zzPwLipKtSXYmft9jKL7F+YuBKt98uxsZx70dOz14gM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PnKnc5jCVprbkHTnVrNet4IxVO8ccJWiL+e25ll0lIQ7y8yRz2Mty2ljZHvNiTC9rnZKIDF3CvxXYCpdNIr2sD8QufE3W9C5oaCoO2YBsezF4Mmf/W2QzC+gT0Qy4vzrNGICwkcmpb0LiZ22WSaE1OkX1UThYAQgpWF9MUgAD+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bIEMmMum; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bIEMmMum" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A48E5C4CEF7; Thu, 9 Apr 2026 19:38:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775763536; bh=zzPwLipKtSXYmft9jKL7F+YuBKt98uxsZx70dOz14gM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bIEMmMum9HbiTU2PcL8KEZ72ZTmR88Plz9CfN3fv7xRjKgB1VMDaD0Cq841jn/k7i +t9RoGm4vb78ggpGOLdVZvHrdbh0A+552k/RlSkE8ooA7PmG/R9nzQiGgByT56xD5M yWWEqP001lZd13CcIEajI8mxVYKutnm0RYF5ueb89sBNCrtUvQ6ElqWtlGQAbC9J4q SgFTHn/54oPZbxTfQ1JXxji+4fZx8Sp/bX5S4PHJ/Mn+eAAIft6JSTe1YBTLvXIW0R quQjxvUeqgwzUlvTi3CFAxSrN21cq7jhYvWLSWGXIgt0gQVhaQDSlyC0gf2l4zSJjg LGCnjvtfAufPw== Received: by finisterre.sirena.org.uk (Postfix, from userid 1000) id 77FAE1AC589F; Thu, 09 Apr 2026 20:32:06 +0100 (BST) Date: Thu, 9 Apr 2026 20:32:06 +0100 From: Mark Brown To: Linus Walleij Cc: Philipp Zabel , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Bartosz Golaszewski , linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2] ASoC: uda1380: Modernize the driver Message-ID: References: <20260409-asoc-uda1380-v2-1-42d02079ecd5@kernel.org> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IBQlhWmMOANbG5oH" Content-Disposition: inline In-Reply-To: <20260409-asoc-uda1380-v2-1-42d02079ecd5@kernel.org> X-Cookie: Are we not men? --IBQlhWmMOANbG5oH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 09, 2026 at 09:17:14PM +0200, Linus Walleij wrote: > This makes the driver usable on contemporary Linux, maybe it will > even work, I can't test it. Don't think so... > @@ -742,6 +745,7 @@ static const struct snd_soc_component_driver soc_component_dev_uda1380 = { > static int uda1380_i2c_probe(struct i2c_client *i2c) > { > struct uda1380_platform_data *pdata = i2c->dev.platform_data; > + struct device *dev = &i2c->dev; > struct uda1380_priv *uda1380; > int ret; We still have the platform data above, and just below this we have: if (!pdata) return -EINVAL; so I'm not sure how the driver is going to instantiate, there's mandatory platform data still. Not that the driver would've instantiated before either with anyhing in mainline... --IBQlhWmMOANbG5oH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmnX/rUACgkQJNaLcl1U h9DfYgf+KVeOLZYMhO/HcnDw03Wz3PAlixx7D8sTvsS9JC/ihgE7CpKdNzX1AtQs /L4wFfXjXmzG5nOF8L/lL2FaldbZh2Dqwik+mJPh+ZDwW01lTubfD5jozFZX2kY+ 30O8CuVfjgfP34I6P7jKj7MtjhS+BUUgX5T2+b7t+6WqxYEwred2hKmsYStA+Rl/ 9cLNmSbgH+xkeCv95vZISrUNImdAH2ilVbsndcLWPws3xb3Zbg+97BmfGGwUI80B T4rKopCjkALMGIWvA4YCqk4ygUrrvsfWhUOE4TJyMZgw8FmAsVE5pN5h1cGVqS2N ygQL7LHngts+17QKOmazH2h2nFIbXQ== =TVEk -----END PGP SIGNATURE----- --IBQlhWmMOANbG5oH--