From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] gpio: sprd: Add missing break in switch statement
Date: Mon, 11 Feb 2019 20:11:14 -0600 [thread overview]
Message-ID: <aeb131be-bc0d-3195-d40d-3c78b334a51a@embeddedor.com> (raw)
In-Reply-To: <CAMz4kuLm66+h_Mo45sTZ1et_wGqDBEv2RRLMU_c+Xip1TEVM-w@mail.gmail.com>
Hi Baolin,
On 2/11/19 8:07 PM, Baolin Wang wrote:
> Hi Gustavo,
>
> On Tue, 12 Feb 2019 at 02:50, Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
>>
>> Fix the following warning by adding a missing break:
>>
>> drivers/gpio/gpio-eic-sprd.c: In function ‘sprd_eic_irq_set_type’:
>> drivers/gpio/gpio-eic-sprd.c:403:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> switch (flow_type) {
>> ^~~~~~
>> drivers/gpio/gpio-eic-sprd.c:435:2: note: here
>> default:
>> ^~~~~~~
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Thanks for fixing my mistake.
> Reviewed-by: Baolin Wang <baolin.wang@linaro.org>
>
Glad to help. :)
Thanks
--
Gustavo
next prev parent reply other threads:[~2019-02-12 2:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 18:50 [PATCH] gpio: sprd: Add missing break in switch statement Gustavo A. R. Silva
2019-02-12 2:07 ` Baolin Wang
2019-02-12 2:11 ` Gustavo A. R. Silva [this message]
2019-02-13 9:40 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeb131be-bc0d-3195-d40d-3c78b334a51a@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=baolin.wang@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=keescook@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).