From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Marco Scardovi <mscardovi95@gmail.com>
Cc: mika.westerberg@intel.com, mathias.nyman@intel.com,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] [PATCH 1/3] gpio: acpi: modernize resource management using cleanup.h
Date: Wed, 6 May 2026 15:51:09 +0300 [thread overview]
Message-ID: <afs5PZgTimaZWs1U@ashevche-desk.local> (raw)
In-Reply-To: <20260506123637.1077421-3-mscardovi95@gmail.com>
On Wed, May 06, 2026 at 02:35:34PM +0200, Marco Scardovi wrote:
No, this is wrong and completely missed the guidelines!
Please, spend near hours to study the Submitting Patches and Coding Style
kernel documentation before preparing and sending a v3.
...
> +#include <linux/cleanup.h>
> +#include <linux/slab.h>
> #include <linux/acpi.h>
> #include <linux/dmi.h>
> #include <linux/errno.h>
...
> +DEFINE_FREE(free_gpio_desc, struct gpio_desc *, {
> + if (_T)
> + gpiochip_free_own_desc(_T);
> +})
> +
> +DEFINE_FREE(acpi_free, void *, {
> + if (_T)
> + ACPI_FREE(_T);
> +})
And yes, these are still subject to comments I gave against v1.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-06 12:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260506113215.GK6785@://intel.com>
2026-05-06 12:34 ` [PATCH v2 0/3] gpio: acpi: modernize resource management using cleanup.h Marco Scardovi
2026-05-06 12:49 ` Andy Shevchenko
2026-05-06 12:35 ` Marco Scardovi
2026-05-06 12:35 ` Marco Scardovi
2026-05-06 12:35 ` [PATCH v2 1/3] [PATCH 1/3] " Marco Scardovi
2026-05-06 12:51 ` Andy Shevchenko [this message]
2026-05-06 12:35 ` [PATCH v2 2/3] [PATCH 2/3] " Marco Scardovi
2026-05-06 12:35 ` [PATCH v2 3/3] [PATCH 3/3] " Marco Scardovi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afs5PZgTimaZWs1U@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mika.westerberg@intel.com \
--cc=mscardovi95@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox