From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99B648248B; Tue, 2 Jun 2026 23:45:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780443941; cv=none; b=C0cTWoPocSYcuzlNAN25l9yiRo9+7gPqw7Bwcc2yEVUOmQGJyduP9GPv1X2nL1GZYrLpLmvNGQ6Ef+SuBFiXdgQaqFwG/xg12c/vNok2SCYLk1DMw60on6/HUFJdlKRyvXvxwnKWlGhspW/o9vNTv+dIvchSLJfLuhi+RIyzKyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780443941; c=relaxed/simple; bh=zCa9Qm1ug0niXbcQ6E3qO9dTYu5hflt0F0ENXLvZVpE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O/6TdOf1Ojlls8au2c199x4gbfjvNfWKUKLCXIUgYPfDzjkXhxyyoYiAzL9r68VWbvqz6bPWXyA9olZ6FYcwqweqJ2TPTY4z3hCieHu2pS0I8E3qWLo/20lWey9BZ+YZrDPLaAnPc/2KOaMNgU9zd5Lg7I+MziZkCAYBAASRYGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VIA9IpqC; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VIA9IpqC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780443941; x=1811979941; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=zCa9Qm1ug0niXbcQ6E3qO9dTYu5hflt0F0ENXLvZVpE=; b=VIA9IpqCWPQK2OIFU0yzs4cFh6DNF98f118bdqMH7/PJgEU5kKZQfyXz od+za2JG8aW5srKpF1S9tN61E3gd9OqBMd9WyTHsMzhIDzvj12CR/6lvU Dgpqa1m8Fr82rQZKtp2l9S8hHTSx6LL76QOWVNtARGoGFMkBKzK9YEN7j pOXhoS0LfoKaDDIIr4OOJBaBA1w+FGR0khp7A0dNYlEHtQMRjGBJGq/6G gB/FzMZYIobkuLnlMNEiGlNQlYz89EJmOosqhgmVLbTogZPaovYSknD3U 53xaxZMU/JE4ypbxcsXrQUndNEIvm69Z0tlx8iF23dP8ZAfIAr1prUjFb g==; X-CSE-ConnectionGUID: 57XsTLrkS+CdHpzLXb5Pgw== X-CSE-MsgGUID: vHOQrcVnQgW/aB4Szvc7XA== X-IronPort-AV: E=McAfee;i="6800,10657,11805"; a="80273063" X-IronPort-AV: E=Sophos;i="6.24,184,1774335600"; d="scan'208";a="80273063" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2026 16:45:39 -0700 X-CSE-ConnectionGUID: js/U7m6lQUCir7ICMqE5Vw== X-CSE-MsgGUID: rpP4asLdS5ifxlq7b0Hy2Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,184,1774335600"; d="scan'208";a="267684643" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.244.116]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2026 16:45:36 -0700 Date: Wed, 3 Jun 2026 02:45:34 +0300 From: Andy Shevchenko To: Dmitry Torokhov Cc: Rich Felker , John Paul Adrian Glaubitz , Yoshinori Sato , Geert Uytterhoeven , Linus Walleij , Bartosz Golaszewski , Arnd Bergmann , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 3/5] sh: mach-rsk: rsk7203: use static device properties for LEDs and GPIO buttons Message-ID: References: <20260520-rsk7203-properties-v2-0-465f3308021b@gmail.com> <20260520-rsk7203-properties-v2-3-465f3308021b@gmail.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Jun 02, 2026 at 03:06:14PM -0700, Dmitry Torokhov wrote: > On Wed, Jun 03, 2026 at 01:02:56AM +0300, Andy Shevchenko wrote: > > On Wed, May 20, 2026 at 10:13:19PM -0700, Dmitry Torokhov wrote: ... > > > + for (i = 0; i < ARRAY_SIZE(rsk7203_devices); i++) { > > > > for (unsigned int i = 0; i < ARRAY_SIZE(rsk7203_devices); i++) { > > > > ...and drop the above definition of i. > > Why? I do not see coding style suggesting this. Linus Torvalds. -- With Best Regards, Andy Shevchenko