Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Hardik Prakash <hardikprakash.official@gmail.com>
Cc: linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org,
	wsa@kernel.org, andriy.shevchenko@intel.com,
	mario.limonciello@amd.com, brgl@bgdev.pl,
	basavaraj.natikar@amd.com, linusw@kernel.org
Subject: Re: [PATCH v8 0/2] i2c: designware: fix WACF2200 touchscreen probe ordering
Date: Fri, 29 May 2026 16:42:07 +0200	[thread overview]
Message-ID: <ahmlvx5gc5y-lYpc@shikoro> (raw)
In-Reply-To: <20260529100838.8896-1-hardikprakash.official@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

On Fri, May 29, 2026 at 03:38:35PM +0530, Hardik Prakash wrote:
> This series fixes the non-functional WACF2200 touchscreen on Lenovo
> Yoga 7 14AGP11 by:
> 
> 1. Reverting the earlier DMI-specific GPIO IRQ quirk (patch 1 of the
>    original series, already in Torvalds' tree) which is no longer
>    needed.
> 
> 2. Adding a generic probe deferral in i2c-designware that walks ACPI
>    child devices, finds GpioInt resources, and defers probe until the
>    referenced GPIO controllers are fully bound.
> 
> Testing confirms patch 2 alone is sufficient — the existing
> amd_gpio_irq_enable() flow works correctly once probe ordering is
> fixed, making the manual IRQ restoration in the reverted patch
> unnecessary.
> 
> The probe ordering race was confirmed via dynamic debug tracing:
> 
>   0.285952  amd_gpio_probe: registering gpiochip  <- GPIO chip visible
>   0.287121  amd_gpio_probe: requesting parent IRQ <- probe still running
>   0.301454  AMDI0010:02 dw_i2c_plat_probe: start  <- races here
>   2.348157  lost arbitration
> 
> Tested on Lenovo Yoga 7 14AGP11 (83TD), Fedora 44, kernel 7.1.0-rc5+.

Shall this go in via i2c?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2026-05-29 14:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29 10:08 [PATCH v8 0/2] i2c: designware: fix WACF2200 touchscreen probe ordering Hardik Prakash
2026-05-29 10:08 ` [PATCH v8 1/2] Revert "pinctrl-amd: enable IRQ for WACF2200 touchscreen on Lenovo Yoga 7 14AGP11" Hardik Prakash
2026-05-29 10:12   ` Mario Limonciello
2026-05-29 20:34   ` Linus Walleij
2026-05-29 10:08 ` [PATCH v8 2/2] i2c: designware: defer probe if child GpioInt controllers are not bound Hardik Prakash
2026-05-29 10:12   ` Mario Limonciello
2026-05-29 14:42     ` Wolfram Sang
2026-05-29 14:43       ` Mario Limonciello
2026-05-29 14:43   ` Wolfram Sang
2026-05-29 20:46     ` Linus Walleij
2026-05-29 20:55       ` Wolfram Sang
2026-05-29 21:59         ` Linus Walleij
2026-05-29 22:46           ` Wolfram Sang
2026-05-29 10:13 ` [PATCH v8 0/2] i2c: designware: fix WACF2200 touchscreen probe ordering Mario Limonciello
2026-05-29 14:42 ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahmlvx5gc5y-lYpc@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=basavaraj.natikar@amd.com \
    --cc=brgl@bgdev.pl \
    --cc=hardikprakash.official@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox