From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FA94243964; Sat, 30 May 2026 10:08:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780135719; cv=none; b=g+Zk4tO84RA2coVPqsF31Pj3yxVcmgi0KTAGiiLiHSj5wrL/+GI7bq25OgvUey5G3UyFqPIbxl7HQSoxJAqFLjuNB/Db1yAInm2BQJj7tsMybyp2wcBY58bR0auB9MSTn+rV+MToPNrOhdofPCSci3Kn4UTE76GLwJQuIlTlN4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780135719; c=relaxed/simple; bh=TOe7mEHFlLQvPkoj0NtPWF/Jz6i3tLW07ecXKhcAtWk=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=DA/f3QsIZuhpFE/yeK4kWrAZiPoihKK36egxx+kx8cXgNrW7WuQYIup669HTBD1Bk8q5PXw/B1d4fJ4YTTTfHWi+GEDyc3WgDuvBnKJA4ZkINalKY8Nw8hHkaK1/0SjIRFdTROuzSC02Wmd7iSP0nSyAJhA4xMReiEkjLBN86Rc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.us; spf=pass smtp.mailfrom=gmx.us; dkim=pass (2048-bit key) header.d=gmx.us header.i=len.bao@gmx.us header.b=dWD/P41z; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.us Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.us header.i=len.bao@gmx.us header.b="dWD/P41z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.us; s=s31663417; t=1780135710; x=1780740510; i=len.bao@gmx.us; bh=TOe7mEHFlLQvPkoj0NtPWF/Jz6i3tLW07ecXKhcAtWk=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:Message-ID: MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=dWD/P41zna4xZZNTklSVvs5TK1vN+gdULHm0RP/rf691Sw6ruYhw5acHwflqIDvm fH4bRAeeYYB+/aMT4ctJH00Aq4SnHsnScb8MEUkZrr0pPePIvXxCZNuXNPjzjBSSH pNkCMcY4VdiYTlZPHfLsAJU+RlYoioT8ZNfocK78TNLYTQywYDWbF3HI8t2zLtRtw i3uo1TZqblcLwuUvgdbHzpddTK6A2YhXsTF5xzscJW8u3zh/+IhmchmLco+YiMlXI 3wMIL/qAkVAUJ5hhSic5pt1V2yNEkjbYLsX87kr+ik8VDRC0jHQ/Gzmlo4X5cjNrs VNVXLtxBDxtbTryVVw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from client.hidden.invalid by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MZTmY-1wppJS2J9C-00MIyc; Sat, 30 May 2026 12:08:29 +0200 Date: Sat, 30 May 2026 10:08:07 +0000 From: Len Bao To: Linus Walleij Cc: Len Bao , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Kees Cook Subject: Re: [PATCH] gpiolib: Mark gpio_devt, gpiolib_initialized and gpio_stub_drv as __ro_after_init Message-ID: Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-Provags-ID: V03:K1:YVhw7+H5pYBzouGiKCzTVplqLibUBf/k3AQcGUZH1ob7rKrKEU6 BvLxRrwPCJ064Wy/oOdOmwfTU9pLOSjd3eK2BY/izMvu0g/P0Ac0WqLRHxa1vPGlX8yzrfh ErJxD/gkM7jwt/cWLTENVfDgcl1N3AKyff3Bs6K1NU9jlNIKsNrII6OrQIoAI2Q60AUghHb GDLQg9tlm7AXCjBly7Zkg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:N9gjyWy0KUY=;OlBxoP34Eh3KZnQgV7nl7/c9fFy c15Po7OOJuL9ga7z/8IkvJK7drAaQ4AXXzFgwpbP7oVilAE9G+etkkverEdMXtussfXKeFh79 Qi8ldI1jny5d1JAgdpG03GRZdN8MnKQVsRT7TxorQDhi4Y3dbfzHk1ScL+2b15Du7yUX6E1Dp Fs86xywEcKvIxkZW7UJPa/UHE8incLRXe+3o7fkxsePiYO9B5sX7V1sXMzbJ+/I5xQ9W/7yon RWP4684u4v8cIlHsxK+wadrEyYi52Rqk1uSf7QejKSKk/whtZ2dG54EOe+crDeNJtY00W72rm wYiXN8RBfbdtRkE3MWjuMNj446vDgg56lfycPZaKIIWB1lFKzZykuo4sp1ADspSGCtqozsDzb VrOE2VFdm0JNWT2P4x1+BK5TMiasEmkwZUXI/jVN/+bXJRdqqMZCRvsJAZhBdRBJi8zuU0B9P DXmFnckMAVN0aL1GrKtr/iLIDOanP/HpIyrFcy21vZtb6YTNXh98Z0fvN31APiqJYZr/o6FUH M3MN11f8sER6WWQw7p2l/Qd2vUE4MZyJKTPYOVJsBARsOwW/LYbI6tT/jdskVNRVrtYQkCqmI OgxC5i3QCtXgfXgf+bF/xJpEYnCI9Ue3/DtBG8ViyLbGo4d1D7ACIpPup1dCKaPSWq0FQyMH3 7RN/pbWsV54oz5KBXhgqCxfY+EqQBl/ZYEnOWm8MCP+9QwE1YZV7iizmPLvMRzuMnt32GrTUC 3hNdE5Z6TccLltq0pYyaSPG7H8kJfM4gcw9HMmqXYXLyuWtbmaIh4iWdbAWJkWleKonRtw8J6 eawe+xlPj7a5q04qnWwmK1Ci1qENr8BrBt6egQCYrvfLQmaksdIS9AA42d9J5B1dHyOHlR7Wg o/rKyx2Nm6uNdnpAtJ66nbcpfawMbZqlPrH7eI3Uu3agp5z+YmtkCmL87fXaAiqixn4qu0Z6q OV7baHnyWCKqYWgLKGWu8y1gCdCZ5o8ck0QOB2S3bYwYykgg8fcbOD5Tw5cw/QWsqHTZ3uxiV YtorpZXrkpWTzdeLAmG/uXhQQnhlVhzRkTooAYY+CG131Qs2HKlkU1YNscvFfT+McXN8DyDJY UC9L04a0v8TAGA569fr/daXN+y4KN0MDOWcYy31hShfMooPFcedcCOccXqRi3a9tEgUsrhonb K3SlSIjv1IrFw8+ygY5z1JykK0F+fm5fFoogFd3+n97uqSgU30ZvavQ5gZhlhrGnx+Mosz4i+ wJtvAEUMyv8ClottkOHHr3K8HHxenScRDwRcL3VGwutXveRq4Qb5NgTWjH3EUl7FEvlowlyOq /LJdoS4iTkDLPyFRPVSPM/c8z555WxFaPMYkUu09ySvkmMZSQVsj50rqhrKBWgsQYy4MRg5Y1 rqsePqnmuU6XKH3HdUuAlL+sWTGYM1e6ocv+pHpgPwwJBbKq98PtREQDMi5Rqna/REvG3W6AZ ybBlIWWk9fYJYgAa4e3IlXQZ6r6ecb5uPfMIVnkhXCN0tYYUG7q0sBvZTBJvJUGdGubOH2gkc 9O7GsWWrRyM4UI5nicpALVuoIIm+hy3XGMV/1Yvh788MNVZPY1LHequgZXcvmPMnjU/sRMvYC ZuvIF9Htv+m6gWdY0tWwDIcQea+0PT1t8fXBgkJzw0wWtDVZtQs/b5sNCgWeD1me3aKVfeSyo UxDhLQ9hUo3gYMK8xUi/xAsA/mVr4j6j4BwlA4ZXjxojaYHm/P27h4QwYMZekQcbnq/ZU8r89 j3Qfsrc7OKmq6EvCgNmCT5Sus1mhyfYzz3rGtR53dYDO7Ts7F/9IGiLik6hS4YKMtQr39sFKP qWzykQPTEy/tzo5zeGYg7urR9/w6E1ecZNSG+3Ce02n1FbgCopiscy6d+jXy7xURWU3BTgPDK qbpXpxFZeoiusOxo63S1uVZGk1viZr/0gpCTclMcO3YK4Hr+l16DFAahilULBCI5O2eKNhlCb 3nhzcZD84+vA9iXHC+cmAe+k+7lfvugu9ijjZZc2F0l5Ginu8KjYKxS92wBVRhRK3GudOwnFT xdaXBY1iLEvS9U8KEl8MH3oEXjqqh8YhChMUd1Knq7BTLl+aTm4m7qpTp4T11iIaZTfh1wAgh IL9oZA65REibVcvQZVnK+g50PlUTL9IYiY4usb1Gtz24EDr/CrMCgmBvbmt88+2m0OL6BaTMz gb9Fjt0P0KwbmLCoTCkA4e9+aDj+ggT6qGzxXB3EFF1gdAOnqeWIR10v2oaQt773Mtd6zGqvi qDRSB11IE+X0/uI063CuoJ4Xk4Mus1/JiwdwdLjkjIBAMH9WUU5tlLdx85GVhj2CgI6c3x9CH vq/2rF6kNZhWhV7epEtl2qd0ssUPMOyqdUBjcwimhASxSGLw8cRmtWjUCL5yENagT/8JYSxBU IScjZPLf2hDfmJVr7Ctj75buKelju857F8UZft6u74OSWsczk6Ly9zaMnzvMdxw2K3hF1fnDw WW+5Mf6HWeT8AOPJA4rzZS6MXBE00s1Qt7WYDGew/5b5UZZPCfAlMIzwjRscHv5MIDjhE890W zKLYBVieZTkRekxfBXs0zDS6zxPC/TE1C5mGEYpvFMpQAg93w0+GlkbvfEEzeF2Zv3SrmalGe 0SLglcgOhnhq/Fwvqs0ojyFe6dtMx9YiR9tqVSS0UJ4z8xVPFaLseyuJ1ZDyxilMqnhHBHtGY n4jPEWW0lKEl6rMuNhjZk3TP3YW8n6Q6SYQWSGfeHmxCl6Sdz/+qHPTUF9zMheKNZEztVRVTR gpS6f4dCDzKtD+BVCVcdW9QlPu5Ufw6ScH99lh2COa2BTp9rh6ef7gNf+A1Ef8C+DGdpSh8xE 5LDrhmWXUD46+LGgIg782EP87vBqbywiLURhOWmB91l8cu1aFxBNU96worXtEmF02txf7XKT7 o9vnccyPPDJzfHIU63vAm5UyxN8vuoecum7hgLe13tUeg2ffkK1pCE8qSMh4IuGg5wpwktrzC HKjV5JnNceyy+GnwcOTAQr42Mil7iZyTI/xVbFWMw9/A/X12FuZ6d+llNdgBeH+UVAFX1FrcV QPM8KaD9kFRfhRDaHWWCspB5xCPdYsWV8t6g/ekBao5MstqRfU5ryKPJ0DFKr0klC4jH4bLIK en0uzArPm+acv7Yil0ZXTQ6teP9ZnylCzq/WqkB1YImz81yGd4fviTwxRPtzmL5wp6kP3gq7g zKlVcAzuKMPyaGBIrpGl7hQ+piL7aMHQ9y4oOMBkErIjOHkx/xJbqGQIc7bt7rmklp7STjRWu bss0UKDLaXP5MLTwAhoFtYRSDmgapmdPGxMVnWAZGumRqCZZv9mnoK/K2Q/qLAXIzyM2H/3z0 vypL0MCwvtvDerR6B0O2NobSzXHVYMH60Z+2SDmqheKla/iATuuIXMt5y3F5CwJoSkwUCPyG7 nBmZrmPRjT+JM/QatXUg0lGE3UngWer+6lWATIX5//DFeNjkeowGXgTNPeNtKBTuJcSHB99j3 vBLxYf5+AwYaZqFNsrYgwo/gX7XfhtkWG+x//rGwwYEdyPFFl16ovu6j0Cdg5x5uDEEGN5laO WVwsLFX5z8aPMxsc91SfhrNHgdFvULcrlgQHiWKBlGb8XCM+lZ9aQoPpsodhDyM6TKhojzgaN ISE7Xk3jwd5J4YHgAHFIXK7yuqyn5FF0yL9ekMH/0x1MiH1WRtPg6nkPyTUtM/7dj1f0fil3X TQnyj5d4X4u6UTExNtN5Ipse2QLEtKb9f5Hra0zmVph2ePvDVwi6l9n9Mylqy8dqmntPDJFtc 1jjWdTyDQn6sqKdKAYQkiQxDaYrrKud/My95clGGvgfaqMrFnGnWCRSien8f3t470eNHA9hOE V924Nw4QWQtGPqfNoPcOS4xxSl8/NNz2FK3FB3bSHHo1o+ZuV5eXxOO6bZ3BVKSyyvlwyYxt3 QB3i+DpdIKdTJkID/+nIlwObxq7kxLeY7CfyFtp7coISXhxhryu1hE57I4wTsityAkJzO7W2C lsi1SqqfvWTcnneEqcqR7FWYbcLSOnST7udd4phuJqxS9/DgHCNvOdBhkkDQvrEr12g/pKLeH 1wkapskuQBATkUks+hPLjCHX9Gcg+AjWvNmhyV+Pt9kePNb6CmFBK2pQRKz6lkovaRnlHKFZ6 yNpJt73WYHTmjzEI1YwVu8rJzbCXmGudJZ5qrw6xzAaMXMc/zP7hbkAojgczm4Kv0WiPhGp7x tBPqdwAVcQjWKi1Qv989wiL3qJJsI/GMsK+wpdI69SsXRiMM+dxNR93uMLKGQBz6KRvs6NkcW YGTIbViDEaHPLwalISFkUceuLzRNRHQyI6kLojUEcxo+FVHUqEqjShtWmm8yjK5/GKpljPemi ahSX2At4y6kpjM9TcQcS70Fuw7ws4nZT7eV84f7/OUl8cY6TIscYQpbJy6woCI0S+mTOI4t4J hPXX7GGF7TGEld9cGrgk0+kTkLJHL28QYqPN5bAbkrspPn3L755HnQArcq41sZXeLex0QG3T7 2DFyiYJgWYBxa9CPEgzqa5ckzvJJQi8seWSvlSo290K/KdnXC8JsHWsrJA3pOaXf/20xtngrb fsq8QKry0yNy40kmfm6wfM7fytG5Tr0woN81kR4S0qFIayIIoTOsAZK34p9w0lMaRu3AMt2zW K7G3++941rVNe7nS0jI77+0WoDOvHEg5z4kxTqXsDvpoGn9+nKB7XA18xnpVMEkcX5bVpxGn3 dEEVIcZ3/g6yCH1l8xB3Y14POue5AtOOfvclqdj1mNt6AeSX8f2+PFvR3mUA4MgNi/zRNlar3 NbgAIV5XPtM7XBYWRN5eAGoUGHR74m/ux7lNqcpaMpN04coAyrEmYMWi1xCmgFb80uhFDZbNJ YjSMLbcqFvb4PPCL/QqybFExGucCniufPBYf4U/+LNrtJLjpWHtxQx7PKjg1TxbpXvHl5Isbi WbnxRBi8pfdZ78WICcuFs+NYl8XMUNWfx2sb3Qe1JWmyMK1uW4Va/vzWl9oAXITv1q2T/ezSo a4HBrtaecyfg7d3uCLQW/QYAzxMALvvacxTpsjalffZwb+HKUPwFI+r87Ylew6kdZUT8MNA4a 7gtIaB//8K6WjkDd40+zLzPIe1osVWw8P97170fvwLn9Gltp0l2VVtTGK5r/gebQ8LMBsmx+n 7HC0RARxbSsubVKB0/bw7UHWs0ZSgpPMKvnXXnbZNokMD25p26l0jZ8IcKdRP4L+VpKFq+gIl 3bhyvQ+/v/JGGHYjVlZ/2GVkGRAvSkxqkD6cGtSDSbsfYgy8LCF1fi+pjiTyGEskr7lAW/JQa hiKSI7649jLN8AR6Mlcvzo2r3kNMP0i9ufZkKqE3A4mMKYex/AqPR7InDoxT78RFvP5qB5e9R sOv1veRdLUJRUZxH2KzuHhpzKBUkKi/7wSC00ddQpEBjTns80C8bnyjsNwLzhJNToUbLb5J/c 0jlG1e6ZInEqVulK8Morj+O/4C9K2aXhqMu6wLWgYl9xG2dWCVJbYnJxSCyvGyyp1cMRgKNwt 8dDtkXKMpxQuAbUo7OCElmU1EU/iaQx3ajdWuHo3mBB10XFHRvqFwYdD3w75l7YZ7d98f3rtQ k0juFIUiWaAFE+FnxbgGNdoBxkcTtAHLZFhhURyITJoMESeVMnlO324D/jqz4Fi59LukwuNk3 4+gCBDi0uIkZxKsH3c= Hi Linus, On Mon, May 25, 2026 at 10:10:02AM +0200, Linus Walleij wrote: > Hi Len, >=20 > thanks for your patch! >=20 > On Sat, May 16, 2026 at 12:58=E2=80=AFPM Len Bao wrote: >=20 > > The 'gpio_devt' and 'gpiolib_initialized' variables are initialized on= ly > > during the init phase in the 'gpiolib_dev_init' function and never > > changed. So, mark these as __ro_after_init. > > > > The 'gpio_stub_drv' variable is initialized only in the declaration an= d > > never changed. So, this variable could be 'const', but using the > > 'driver_register' and 'driver_unregister' functions discards the 'cons= t' > > qualifier. Therefore, as an alternative, mark it as a __ro_after_init. > > > > Signed-off-by: Len Bao >=20 > Patches like this should be CC to linux-hardening. Ok, next time I will CC to linux-hardening. Thanks for the guidance. > Anyways it looks good to me! > Reviewed-by: Linus Walleij Thanks for your time to look at this. Regards, Len Bao > Yours, > Linus Walleij