From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] gpio: don't process hogs on disabled nodes
Date: Tue, 9 Jun 2026 17:16:36 +0300 [thread overview]
Message-ID: <aiggRCmJ8FQEMDib@ashevche-desk.local> (raw)
In-Reply-To: <20260609-gpio-hogs-fixes-v1-1-b4064f8070e7@oss.qualcomm.com>
On Tue, Jun 09, 2026 at 02:17:49PM +0200, Bartosz Golaszewski wrote:
> The core hogging logic uses device_for_each_child_node_scoped(), which
> iterates over all child firmware nodes without checking their
> availability. Before the code was moved to the GPIO core, it correctly
> used for_each_available_child_of_node_scoped() to skip disabled nodes.
> Check if the node is available and skip it if not.
...
> device_for_each_child_node_scoped(&gc->gpiodev->dev, fwnode) {
> - if (!fwnode_property_present(fwnode, "gpio-hog"))
> + if (!fwnode_device_is_available(fwnode) ||
> + !fwnode_property_present(fwnode, "gpio-hog"))
> continue;
Red herring. the device_for_each_child_node*() is already "available".
So, teach Sashiko to stop on this, not the first time...
https://elixir.bootlin.com/linux/v7.1-rc7/source/drivers/of/property.c#L1132
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-09 14:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 12:17 [PATCH 0/2] gpio: fix regressions in GPIO hogs after the code refactoring Bartosz Golaszewski
2026-06-09 12:17 ` [PATCH 1/2] gpio: don't process hogs on disabled nodes Bartosz Golaszewski
2026-06-09 14:16 ` Andy Shevchenko [this message]
2026-06-09 14:33 ` Bartosz Golaszewski
2026-06-09 12:17 ` [PATCH 2/2] gpio: fix cleanup path on hog failure Bartosz Golaszewski
2026-06-09 14:25 ` Andy Shevchenko
2026-06-09 14:33 ` Bartosz Golaszewski
2026-06-09 14:50 ` Andy Shevchenko
2026-06-09 12:47 ` [PATCH 0/2] gpio: fix regressions in GPIO hogs after the code refactoring Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiggRCmJ8FQEMDib@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox