From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBF853E169E; Mon, 29 Jun 2026 14:35:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782743760; cv=none; b=rvJ2THwrWbAyFm36O5MZWXA5vmi0P2p0XhVx1gzrSEjkc48TBqCcb52WYnONnMRi2DwYDIWpxM05AY+pjtNcT5lHaoAKbL+ptCyyYZFkLk7VkgVkgV49zuOndA3DHqbiG/7vTPed8njSgswWN9BWSo3apKXHstXiopCvcjIkDBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782743760; c=relaxed/simple; bh=qadMrehZipQBP0SK0FEIR9R8NAJ0UU3ERZJptjWc3Ws=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y1LZkacCmcgUtmZf2bBAoXXWRVWHcSM/K+7FnqJsZ+2le5eg5MCrgz+wAuGlMk88/BxC8s/K54NvdtY5pyAzeS8jGFmIAQ7q5MRya+MUJOTO67ngQKaiBe8KMfvy5erC/nCKJ20JxA4AFOO290q8cjhpb7R5Q4MmR4+RnHkBXDs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MIwUD5NB; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MIwUD5NB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782743759; x=1814279759; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qadMrehZipQBP0SK0FEIR9R8NAJ0UU3ERZJptjWc3Ws=; b=MIwUD5NBcdkigX9aNnpyao4UpHEFXg44hhy2XNqFZAyMhns6Q42AV5Sq CRY9oZ/BxhELg5uUxAeD/oaj63500Bo8A1q4xhs9vgOE7THjvmXoaN8xu v9GEyMEFJdWWPStTz7ghIWia2sc49a2rZfGUCHfUUyzYoR26CLd0hRW0B utIh/4J/n1E4GcxUtLR4f4H7hY24AQmF1LquGtVXPbd+KHW5I153lWFey 5xlQNzpr5DIdW3YPjVeuZdBh6k3K1TSUaF9iBJUylz3R/XELnXXf90QZI A80kwX8Yh+gsfnKcy7GVsoHxOsVEpdZB7B6n1m9TjzsYAXQd+HIkXf2Hn Q==; X-CSE-ConnectionGUID: 8sQ9+YejTfKXbnWJEV00nw== X-CSE-MsgGUID: HyzVzSXNQhymOJIpFpFpiw== X-IronPort-AV: E=McAfee;i="6800,10657,11832"; a="83308752" X-IronPort-AV: E=Sophos;i="6.24,232,1774335600"; d="scan'208";a="83308752" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2026 07:35:58 -0700 X-CSE-ConnectionGUID: YWmC+1XOSc2qoy3jMewjgw== X-CSE-MsgGUID: cFd+FRyQSiOxP2AmOj47hw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,232,1774335600"; d="scan'208";a="253876941" Received: from kniemiec-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.207]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2026 07:35:56 -0700 Date: Mon, 29 Jun 2026 17:35:54 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Dmitry Torokhov , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH] gpio: swnode: remove deprecated lookup mechanism Message-ID: References: <20260629-gpio-swnode-drop-label-matching-v1-1-db1af36cf883@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Jun 29, 2026 at 07:04:43AM -0700, Bartosz Golaszewski wrote: > On Mon, 29 Jun 2026 15:10:40 +0200, Andy Shevchenko > said: > > On Mon, Jun 29, 2026 at 12:54:58PM +0200, Bartosz Golaszewski wrote: ... > >> fwnode_lookup: > >> - gdev = gpio_device_find_by_fwnode(fwnode); > > > >> - return gdev ?: ERR_PTR(-EPROBE_DEFER); > > > > Can we simply leave these two instead? > > Honestly, that's just personal preference. I prefer the oneliner. I was under impression that gdev variable has use after this, but LKP showed that you missed its removal. With that in mind, I have no objections against oneliner. -- With Best Regards, Andy Shevchenko