From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54A3047F2F7; Wed, 1 Jul 2026 11:38:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782905923; cv=none; b=Q0vO9IQreBQvfRgcqj4GIxwP/z25YU0KxccUMlNAYfTMeCq/WpJ5EQwEM/qvIh19tCFaAgH2hK7XmNn+3M7OLBANR1T5AX4F0soMlqV0wcd5nPZIosgXeC1gzSCarD1qO6tpfW6vrvbNZiO9tuwj+gB7ePGT0etQ4H9ZrjKD6qI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782905923; c=relaxed/simple; bh=DpQi5aHD1Rq2oQdH6gtw9i/QhFrOv7rlYgtQDdcfbSU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KdSoIL0bP/mMHUxMAHO1u5uOktJ2BSe+455343FXP0L6kg5jkZ03ecSe1ZVmhZ/92CO3CYPTu5atAFmknDzKYPgqedKkJ3+uRI0WVQw3aGuLRKn0eu81SCpYGJO2fvLBCOmtyTsHOxkIsNbzopvxN9PsseBuF8Xk98wYOPsomo4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=aGxMsGES; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="aGxMsGES" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782905920; x=1814441920; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=DpQi5aHD1Rq2oQdH6gtw9i/QhFrOv7rlYgtQDdcfbSU=; b=aGxMsGES/LhpIHmr7dstHzYYNGzm/u7ARkVQ6ErmN5nB4Hbh4rE0MUhH G2Fb9EbuRpG4WLz79v9g9mFCgn5eNQbyH9sMm3ZplCoeXTSK/W0XrWc8G WcmQtxsUIR9FV+/TAkuZEse07oZ9CMPV1mU1Nid/NDI9jrETbS2nFSmRg lw3ZcdhEEuPBUsYuPtE0i+hMYccFUVyKgww9qWnmtKLmJWkRy9+aYQYu7 Hgcyu9a+PVvOfDLeD1R1gWY/TAMagd87fF3mmf3PrregcXUDX4Lt4TjdY sn9nmC5kaPEbBPXJg7ct2qBldmxFz+mGs6fEGYnSld3rticnNsGzZods1 Q==; X-CSE-ConnectionGUID: 03oF66lRTfy/Y8+Fj2523Q== X-CSE-MsgGUID: NuqeR+T1SiqgDIeiJ7ZFpA== X-IronPort-AV: E=McAfee;i="6800,10657,11833"; a="87471921" X-IronPort-AV: E=Sophos;i="6.25,141,1779174000"; d="scan'208";a="87471921" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2026 04:38:38 -0700 X-CSE-ConnectionGUID: rTQDfgZ4RGq/h2rchLoSMQ== X-CSE-MsgGUID: VAriTwrzQjasz3AnxY77QA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,141,1779174000"; d="scan'208";a="257446464" Received: from conormcd-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.244.65]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2026 04:38:32 -0700 Date: Wed, 1 Jul 2026 14:38:30 +0300 From: Andy Shevchenko To: Andy Shevchenko Cc: Michael Walle , Linus Walleij , Bartosz Golaszewski , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "afaerber@suse.com" , "wbg@kernel.org" , "mathieu.dubois-briand@bootlin.com" , "lars@metafoo.de" , "Michael.Hennerich@analog.com" , "jic23@kernel.org" , "nuno.sa@analog.com" , "andy@kernel.org" , "dlechner@baylibre.com" , =?utf-8?B?VFlfQ2hhbmdb5by15a2Q6YC4XQ==?= , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-realtek-soc@lists.infradead.org" , "linux-iio@vger.kernel.org" , =?utf-8?B?Q1lfSHVhbmdb6buD6Ymm5pmPXQ==?= , Stanley =?utf-8?B?Q2hhbmdb5piM6IKy5b63XQ==?= , James Tai =?utf-8?B?W+aItOW/l+WzsF0=?= , Yu-Chun Lin =?utf-8?B?W+ael+elkOWQm10=?= Subject: Re: [PATCH v3 2/7] gpio: regmap: add gpio_regmap_get_gpiochip() accessor Message-ID: References: <20260512033317.1602537-3-eleanor.lin@realtek.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Jul 01, 2026 at 01:55:11PM +0300, Andy Shevchenko wrote: > On Wed, Jul 01, 2026 at 01:01:10PM +0300, Andy Shevchenko wrote: > > On Wed, Jul 1, 2026 at 11:44 AM Michael Walle wrote: > > > On Fri Jun 19, 2026 at 11:08 PM CEST, Linus Walleij wrote: > > > > On Mon, Jun 8, 2026 at 4:41 PM Michael Walle wrote: > > > > > > > >> >>> Without an accessor like gpio_regmap_get_gpiochip(), we cannot retrieve the > > > >> >>> gpio_chip instantiated inside gpio-regmap.c to fulfill these requirements in our > > > >> >>> map() function. > > > >> > > > >> Why is gpiochip_irq_reqres() called in the first place? Isn't that > > > >> only called if the irq handling is set up via gc->irq.chip and not > > > >> via gpiochip_irqchip_add_domain() like in gpio-regmap? > > > > > > > > Not really, the gpiochip_irq_reqres() is called to mark that a > > > > GPIO line is used for IRQ, so the gpiolib cannot turn this > > > > GPIO into an output line, gpiod_direction_out() will fail > > > > on lines used for IRQ. So it's a failsafe. > > > > > > > > You can live without it of course, but then you don't get > > > > this failsafe. > > > > > > Thanks for the explanation! So did I make a mistake years ago by > > > adding the gpiochip_irqchip_add_domain(), see commit 6a45b0e2589f > > > ("gpiolib: Introduce gpiochip_irqchip_add_domain()") > > > > > > As Yu-Chun found, gpiochip_irq_reqres() expect the irq chip data > > > to be a gpio_chip, which isn't the case (in general) for an > > > externally allocated domain, is it? > > > > So the whole issue comes from the fact that the IRQ chip is not marked > > as immutable. For immutable IRQ chips (which all GPIO provides should > > have) there is no such issue to begin with, id est there is no > > gpiochip_irq_reqres() callback assigned (and respective _relres). > > Ah, for immutable chips we put either custom ones or > GPIOCHIP_IRQ_RESOURCE_HELPERS which actually refers to those callbacks. > > So, if the domain is external, it should also provide irq_request_resources > and release callbacks. In the custom case we can wrap gpiochip_reqres_irq() > and gpiochip_relres_irq() respectively. > > But we need to have a struct gpio_chip pointer for them. And note, the > IRQ chip data can be anything in that case, so it's not a requirement. And looking back for implementation in v3 the whole mistake was to use GPIOCHIP_IRQ_RESOURCE_HELPERS. It just wanted custom callbacks with the IRQ chip data assigned to whatever from which we may then deduce struct gpio_chip. It does *not* require to be struct gpio_chip. The local driver data structure should keep pointer to struct gpio_regmap. That one can be used in the respective .irq_request_resources() and .irq_release_resources(). The default ones for gpio-regmap may also be provided via a macro, say GPIO_REGMAP_IRQ_RESOURCE_HELPERS. Hence I don't see the need of having gpio_regmap_get_gpiochip() helper and driver can be implemented using gpio-regmap and external IRQ domain. What did I miss? -- With Best Regards, Andy Shevchenko