From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <david@davidgow.net>, Rae Moar <raemoar63@gmail.com>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-acpi@vger.kernel.org,
driver-core@lists.linux.dev, linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Subject: Re: [PATCH 5/5] gpio: kunit: add test cases verifying swnode devlink support
Date: Mon, 6 Jul 2026 23:09:39 +0300 [thread overview]
Message-ID: <akwLg6XiA6eJblH2@ashevche-desk.local> (raw)
In-Reply-To: <CAMRc=Md1K_ZfO7pUANNhCkwEpmF6nX-Wo=AeuiO57hjKLtWDWg@mail.gmail.com>
On Mon, Jul 06, 2026 at 08:32:28AM -0400, Bartosz Golaszewski wrote:
> On Mon, 29 Jun 2026 17:58:16 +0200, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> said:
> > On Mon, Jun 29, 2026 at 12:52:10PM +0200, Bartosz Golaszewski wrote:
...
> >> +static int gpio_probe_defer_consumer_probe(struct platform_device *pdev)
> >> +{
> >> + struct device *dev = &pdev->dev;
> >> + struct gpio_probe_defer_pdata *pdata = dev_get_platdata(dev);
> >> + struct gpio_desc *desc;
> >
> >> + pdata->probe_count++;
> >
> > Even in case of error?
>
> We're counting how many times we *enter* probe, so yes, I think it's right.
Perhaps a (short) comment on top of this line?
/* Count probes independently on being successful or unsuccessful */
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-06 20:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 10:52 [PATCH 0/5] software node: provide support for fw_devlink Bartosz Golaszewski
2026-06-29 10:52 ` [PATCH 1/5] kunit: provide a set of fwnode-oriented helpers Bartosz Golaszewski
2026-06-29 10:52 ` [PATCH 2/5] software node: add fw_devlink support Bartosz Golaszewski
2026-06-29 15:42 ` Andy Shevchenko
2026-06-30 6:16 ` Herve Codina
2026-07-06 11:34 ` Bartosz Golaszewski
2026-06-29 10:52 ` [PATCH 3/5] software node: add kunit tests for " Bartosz Golaszewski
2026-06-29 15:49 ` Andy Shevchenko
2026-07-06 11:42 ` Bartosz Golaszewski
2026-07-06 20:05 ` Andy Shevchenko
2026-07-07 7:27 ` Bartosz Golaszewski
2026-06-29 10:52 ` [PATCH 4/5] MAINTAINERS: add myself as reviewer of software node support Bartosz Golaszewski
2026-06-29 11:20 ` Andy Shevchenko
2026-06-29 10:52 ` [PATCH 5/5] gpio: kunit: add test cases verifying swnode devlink support Bartosz Golaszewski
2026-06-29 15:58 ` Andy Shevchenko
2026-07-06 12:32 ` Bartosz Golaszewski
2026-07-06 20:09 ` Andy Shevchenko [this message]
2026-07-07 7:25 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akwLg6XiA6eJblH2@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brendan.higgins@linux.dev \
--cc=brgl@kernel.org \
--cc=dakr@kernel.org \
--cc=david@davidgow.net \
--cc=djrscally@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kunit-dev@googlegroups.com \
--cc=linusw@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=raemoar63@gmail.com \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox