From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Linus Walleij <linusw@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] gpiolib: remove trailing comma from sentinel in GPIO_LOOKUP_SINGLE
Date: Wed, 15 Jul 2026 11:36:22 +0300 [thread overview]
Message-ID: <aldGhpswOfyjd8vO@ashevche-desk.local> (raw)
In-Reply-To: <CAMRc=MckJVi5bPtBh9p9D3SHaJcyvf19B2J-u7fbDiTA=CLdJA@mail.gmail.com>
On Wed, Jul 15, 2026 at 08:11:06AM +0000, Bartosz Golaszewski wrote:
> On Tue, 14 Jul 2026 10:41:39 +0200, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> said:
> > On Mon, Jul 13, 2026 at 04:29:16PM -0700, Dmitry Torokhov wrote:
> >> The GPIO_LOOKUP_SINGLE macro defines a lookup table with a single entry
> >
> > GPIO_LOOKUP_SINGLE()
>
> I fixed it when applying.
Thanks!
> >> followed by an empty sentinel entry. The sentinel entry has a trailing
> >> comma which is unnecessary. Remove it.
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> I queued it but I do consider it a bit of a needless churn TBH.
You should really be against Uwe's patches then! :-)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-15 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 23:29 [PATCH] gpiolib: remove trailing comma from sentinel in GPIO_LOOKUP_SINGLE Dmitry Torokhov
2026-07-14 8:41 ` Andy Shevchenko
2026-07-15 8:11 ` Bartosz Golaszewski
2026-07-15 8:36 ` Andy Shevchenko [this message]
2026-07-15 9:08 ` Bartosz Golaszewski
2026-07-15 8:10 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aldGhpswOfyjd8vO@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox