From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Miao Wang <shankerwangmiao@gmail.com>
Cc: Xi Ruoyao <xry111@xry111.site>,
Bartosz Golaszewski <brgl@kernel.org>,
Miao Wang via B4 Relay
<devnull+shankerwangmiao.gmail.com@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Jianmin Lv <lvjianmin@loongson.cn>,
WANG Xuerui <kernel@xen0n.name>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
linux-gpio@vger.kernel.org, Yinbo Zhu <zhuyinbo@loongson.cn>,
Linus Walleij <linusw@kernel.org>,
Hongchen Zhang <zhanghongchen@loongson.cn>,
Liu Peibao <liupeibao@loongson.cn>,
Juxin Gao <gaojuxin@loongson.cn>,
Mika Westerberg <westeri@kernel.org>,
Mingcong Bai <jeffbai@aosc.io>
Subject: Re: [PATCH RFC] gpio: loongson-64bit: Add back the support for gsi_idx_map
Date: Fri, 17 Jul 2026 00:35:29 +0300 [thread overview]
Message-ID: <allOoYUZXocOfk8F@ashevche-desk.local> (raw)
In-Reply-To: <782E1F07-5E90-42D2-A2E6-4404C53B4C05@gmail.com>
On Mon, Jul 06, 2026 at 10:45:48PM +0800, Miao Wang wrote:
> > 2026年7月6日 22:26，Xi Ruoyao <xry111@xry111.site> 写道：
> > On Mon, 2026-07-06 at 19:43 +0800, Miao Wang wrote:
...
> >>> So, let me state again, we need an input from Loongson on clarification on what
> >>> to do with the property. Because what I read from your reply is that property
> >>> must stay and specification update was a wrong move.
> >>
> >> If Interrupt() repeated in _CRS is allowed, then I don't think it is a wrong
> >> move, but we are considering about existing hardware and firmware which are
> >> not following this change. If repeated Interrupt() is not allowed, then this
> >> would be another story.
ACPI seems have no limitations in that. The problematic part might or might not be
the ACPI glue layer in the Linux kernel. The interrupts from the ACPI table are being
converted to IORESOURCE_IRQ for the platform devices.
Looking closer at the code I think it's allowed for the platform devices. For
the SerialBus ones it's not supported as they are using the single interrupt.
This is platform device, so it should work.
> > If repeated Interrupt() is not allowed (I'm unsure yet if it's allowed
> > too) we can still use the hard coded logic like m % 8 or MIN(m, 4)
> > instead of gsi_idx_map. AFAIK these mappings are hard-wired in the chip
> > (i.e. not programmable by the firmware) so having the _HID is enough.
> So will this PoC work?
I think your initial approach to just read an outdated property is KISS.
This all smells like over engineering (since Loongson hasn't given any
details on the topic).
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-07-16 21:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 21:05 [PATCH RFC] gpio: loongson-64bit: Add back the support for gsi_idx_map Miao Wang via B4 Relay
2026-06-30 7:45 ` Bartosz Golaszewski
2026-06-30 12:07 ` Andy Shevchenko
2026-06-30 12:42 ` Miao Wang
2026-07-01 7:36 ` Andy Shevchenko
2026-07-01 8:07 ` Miao Wang
2026-07-01 8:37 ` Andy Shevchenko
2026-07-01 8:56 ` Miao Wang
2026-07-01 9:45 ` Andy Shevchenko
2026-07-05 17:55 ` Xi Ruoyao
2026-07-06 5:19 ` Andy Shevchenko
2026-07-06 11:43 ` Miao Wang
2026-07-06 14:26 ` Xi Ruoyao
2026-07-06 14:45 ` Miao Wang
2026-07-16 21:35 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=allOoYUZXocOfk8F@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=devnull+shankerwangmiao.gmail.com@kernel.org \
--cc=gaojuxin@loongson.cn \
--cc=jeffbai@aosc.io \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=lvjianmin@loongson.cn \
--cc=shankerwangmiao@gmail.com \
--cc=westeri@kernel.org \
--cc=xry111@xry111.site \
--cc=zhanghongchen@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox