From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1207C2D0C8 for ; Sat, 28 Dec 2019 21:39:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81BE9207E0 for ; Sat, 28 Dec 2019 21:39:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726684AbfL1VjM (ORCPT ); Sat, 28 Dec 2019 16:39:12 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:55873 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726640AbfL1VjM (ORCPT ); Sat, 28 Dec 2019 16:39:12 -0500 X-IronPort-AV: E=Sophos;i="5.69,368,1571695200"; d="scan'208";a="334350057" Received: from abo-154-110-68.mrs.modulonet.fr (HELO hadrien) ([85.68.110.154]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Dec 2019 22:39:09 +0100 Date: Sat, 28 Dec 2019 22:39:08 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Linus Walleij cc: linux-gpio@vger.kernel.org, kbuild-all@lists.01.org Subject: [PATCH] usb: phy: phy-gpio-vbus-usb: fix odd_ptr_err.cocci warnings Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: kbuild test robot Inconsistent IS_ERR and PTR_ERR on line 291. Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Fixes: ec84cd4d1bb8 ("usb: phy: phy-gpio-vbus-usb: Convert to GPIO descriptors") Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git gpio-descriptors-usb head: ec84cd4d1bb85874b0ed3f5e4e567fb2ccb956bd commit: ec84cd4d1bb85874b0ed3f5e4e567fb2ccb956bd [6/6] usb: phy: phy-gpio-vbus-usb: Convert to GPIO descriptors :::::: branch date: 6 hours ago :::::: commit date: 6 hours ago phy-gpio-vbus-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/phy/phy-gpio-vbus-usb.c +++ b/drivers/usb/phy/phy-gpio-vbus-usb.c @@ -288,7 +288,7 @@ static int gpio_vbus_probe(struct platfo gpio_vbus->pullup_gpiod = devm_gpiod_get_optional(dev, "pullup", GPIOD_OUT_LOW); if (IS_ERR(gpio_vbus->pullup_gpiod)) { - err = PTR_ERR(gpio_vbus->vbus_gpiod); + err = PTR_ERR(gpio_vbus->pullup_gpiod); dev_err(&pdev->dev, "can't request pullup gpio, err: %d\n", err); return err;