From: Benjamin Boortz <bennib@mailbox.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: linusw@kernel.org, andy.shevchenko@gmail.com, lee@kernel.org,
vladimir.oltean@nxp.com, colin.foster@in-advantage.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v2] pinctrl: microchip-sgpio: add missing select REGMAP_MMIO
Date: Sun, 19 Jul 2026 17:00:05 +0200 [thread overview]
Message-ID: <alzlLy15fAFPuLSz@bb-82jq> (raw)
In-Reply-To: <alydngVPPaqCoaw9@ashevche-desk.local>
On Sun, Jul 19, 2026 at 12:49:18PM +0300, Andy Shevchenko wrote:
>On Sun, Jul 19, 2026 at 11:41:46AM +0200, Benjamin Boortz wrote:
>> The driver calls ocelot_regmap_from_resource() via <linux/mfd/ocelot.h>,
>> which internally uses devm_regmap_init_mmio() and requires REGMAP_MMIO.
>> The Kconfig entry does not select REGMAP_MMIO, causing a build failure
>> when no other driver in the config happens to pull in REGMAP_MMIO:
>>
>> include/linux/mfd/ocelot.h:34:24: error: implicit declaration of function 'devm_regmap_init_mmio'
>>
>> Found by randconfig testing on arm64; tinyconfig reproducer below.
>>
>> Fixes: 2afbbab45c26 ("pinctrl: microchip-sgpio: update to support regmap")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Benjamin Boortz <bennib@mailbox.org>
>> Reviewed-by: Andy Shevchenko <andy@kernel.org>
>> ---
>
>This is v2. It misses a changelog here.
>
>No need to resend _this_ time, just reply to this query with
>what has been changed v1..v2.
>
>--
>With Best Regards,
>Andy Shevchenko
>
>
Changes in v2:
- Reduced error block to one most significant line
- Fixed Fixes: tag to 2afbbab45c26 ("pinctrl: microchip-sgpio: update to support regmap")
- Added Reviewed-by
BR,
Benni Boortz
prev parent reply other threads:[~2026-07-19 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 9:41 [PATCH v2] pinctrl: microchip-sgpio: add missing select REGMAP_MMIO Benjamin Boortz
2026-07-19 9:49 ` Andy Shevchenko
2026-07-19 15:00 ` Benjamin Boortz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alzlLy15fAFPuLSz@bb-82jq \
--to=bennib@mailbox.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=colin.foster@in-advantage.com \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox