> Switching them to debugfs_create_file() would just add a second > get/put around the one they already do, so I would leave them. > > Happy to send a follow-up if you'd prefer them consistent. I would prefer them to be consistent. The overhead is negligible IMO. If you prefer to leave them, ok, too. Then, I'd just ask you to add a comment why this one file is different than the others. Because it stands out and it is not directly obvious why. Thank you for looking into this!