From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Yu-Chun Lin <eleanor.lin@realtek.com>
Cc: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
James Tai <james.tai@realtek.com>,
Tzuyi Chang <tychang@realtek.com>,
CY Huang <cy.huang@realtek.com>,
Stanley Chang <stanley_chang@realtek.com>
Subject: Re: [PATCH v3 4/7] gpio: rtd1625: Narrow 'i' variable scope in loop
Date: Mon, 17 Aug 2026 11:14:41 +0300 [thread overview]
Message-ID: <aoLC8frbgn3fJ5Kc@ashevche-desk.local> (raw)
In-Reply-To: <20260816-gpio-cleanup-v3-4-f298cdd65fca@realtek.com>
On Sun, Aug 16, 2026 at 11:17:33PM +0800, Yu-Chun Lin wrote:
> Declare 'i' inside the for-loop header to reduce variable visibility.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-17 8:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-16 15:17 [PATCH v3 0/7] gpio: rtd1625: minor cleanups and log improvements Yu-Chun Lin
2026-08-16 15:17 ` [PATCH v3 1/7] gpio: rtd1625: Remove unnecessary blank line Yu-Chun Lin
2026-08-17 8:13 ` Andy Shevchenko
2026-08-16 15:17 ` [PATCH v3 2/7] gpio: rtd1625: Drop unneeded initializations Yu-Chun Lin
2026-08-17 8:14 ` Andy Shevchenko
2026-08-16 15:17 ` [PATCH v3 3/7] gpio: rtd1625: Fix variable type for regmap_read() Yu-Chun Lin
2026-08-16 15:17 ` [PATCH v3 4/7] gpio: rtd1625: Narrow 'i' variable scope in loop Yu-Chun Lin
2026-08-17 8:14 ` Andy Shevchenko [this message]
2026-08-16 15:17 ` [PATCH v3 5/7] gpio: rtd1625: Narrow 'hwirq' " Yu-Chun Lin
2026-08-17 8:15 ` Andy Shevchenko
2026-08-16 15:17 ` [PATCH v3 6/7] gpio: rtd1625: Replace pr_err_ratelimited() with dev_err_ratelimited() Yu-Chun Lin
2026-08-16 15:17 ` [PATCH v3 7/7] gpio: rtd1625: Use IRQ_TYPE_DEFAULT macro Yu-Chun Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoLC8frbgn3fJ5Kc@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=brgl@kernel.org \
--cc=cy.huang@realtek.com \
--cc=eleanor.lin@realtek.com \
--cc=james.tai@realtek.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stanley_chang@realtek.com \
--cc=tychang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox