From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Janani Sunil <janani.sunil@analog.com>
Cc: "Michael Walle" <mwalle@kernel.org>,
"Linus Walleij" <linusw@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Nuno Sá" <nuno.sa@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Janani Sunil" <jananisunil.dev@gmail.com>
Subject: Re: [PATCH v7 3/3] gpio: ad7768: Add AD7768 GPIO auxiliary driver
Date: Tue, 8 Sep 2026 13:47:06 +0300 [thread overview]
Message-ID: <ap_nqnPLWJpz5N8o@ashevche-desk.local> (raw)
In-Reply-To: <20260908-ad7768-gpio-v7-3-52ee6ef18a1e@analog.com>
On Tue, Sep 08, 2026 at 09:24:54AM +0200, Janani Sunil wrote:
> The AD7768 provides five GPIOs controlled through registers shared
> with the parent IIO device. Register an auxiliary gpio-regmap driver
> and use the parent device for runtime PM.
>
> The device has separate input-state and output-latch registers. Add a
> reg_mask_xlate() callback that checks the line direction and reads the
> programmed output latch for output lines while retaining input-state
> reads for input lines.
...
> + if (ngpios > AD7768_FILTER_GPIO &&
> + device_property_match_string(gc->parent->parent, "clock-names",
> + "mclk") < 0)
Looking at the length of the line I have just noticed that this uses
gc->parent->parent. Here is the question: what does gc->fwnode refer to?
> + __clear_bit(AD7768_FILTER_GPIO, valid_mask);
> +
> + return 0;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-08 10:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 7:24 [PATCH v7 0/3] gpio: Add AD7768 GPIO support Janani Sunil
2026-09-08 7:24 ` [PATCH v7 1/3] gpio: regmap: Use regmap_test_bits() for single bit reads Janani Sunil
2026-09-08 7:24 ` [PATCH v7 2/3] gpio: regmap: Add optional runtime PM support Janani Sunil
2026-09-08 7:24 ` [PATCH v7 3/3] gpio: ad7768: Add AD7768 GPIO auxiliary driver Janani Sunil
2026-09-08 10:47 ` Andy Shevchenko [this message]
2026-09-10 15:07 ` Janani Sunil
2026-09-10 15:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap_nqnPLWJpz5N8o@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=brgl@kernel.org \
--cc=janani.sunil@analog.com \
--cc=jananisunil.dev@gmail.com \
--cc=jic23@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mwalle@kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox