From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "David Lechner (TI)" <dlechner@baylibre.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Linus Walleij" <linusw@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, "Chris Hall" <c-hall@ti.com>,
"Patrick Edwards" <pedwards@ti.com>,
"Kurt Borja" <kuurtb@gmail.com>
Subject: Re: [PATCH v2 2/2] iio: adc: ti-ads112c14: add gpio support
Date: Tue, 13 Oct 2026 17:07:28 +0300 [thread overview]
Message-ID: <as47IMM9rtBCAH0-@ashevche-desk.local> (raw)
In-Reply-To: <20261009-iio-adc-ti-ads112c14-gpio-v2-2-3231a795fa63@baylibre.com>
On Fri, Oct 09, 2026 at 06:25:52PM -0500, David Lechner (TI) wrote:
> Add support for using the AIN4/GPIO0 to AIN7/GPIO3 pins as GPIOs when
> the gpio-controller property is present.
>
> Pins that are already used for something else according to the
> devicetree are excluded from the valid GPIO mask. This includes analog
> inputs and excitation current outputs used by channels, REFP/REFN when
> an external reference is used, the /FAULT and /DRDY interrupts and the
> external clock input.
...
> + for (unsigned int i = 0; i < ADS112C14_NUM_GPIO; i++) {
> + data->gpio_names[i] = devm_kasprintf(dev, GFP_KERNEL, "%s:GPIO%u",
> + dev_name(&indio_dev->dev), i);
> + if (!data->gpio_names[i])
> + return -ENOMEM;
> + }
I am sorry, I still didn't get what's wrong with the dash (technically
speaking)? So, this may use devm_kasprintf_strarray().
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-10-13 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 23:25 [PATCH v2 0/2] iio: adc: ti-ads112c14: add gpio support David Lechner (TI)
2026-10-09 23:25 ` [PATCH v2 1/2] iio: adc: ti-ads112c14: parameterize GPIO register field macros David Lechner (TI)
2026-10-10 9:00 ` Bartosz Golaszewski
2026-10-09 23:25 ` [PATCH v2 2/2] iio: adc: ti-ads112c14: add gpio support David Lechner (TI)
2026-10-10 9:00 ` Bartosz Golaszewski
2026-10-10 13:46 ` David Lechner
2026-10-13 14:05 ` Andy Shevchenko
2026-10-13 14:07 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as47IMM9rtBCAH0-@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=brgl@kernel.org \
--cc=c-hall@ti.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kuurtb@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pedwards@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox