Re: [PATCH v2 1/5] dt-bindings: pinctrl: add the NXP LX2160A RCW pad mux

[Vincent Jardin <vjardin@free.fr>]

Hi M. Bot,

> > +          enum: [ iic1, iic2, iic3, iic4, iic5, iic6, xspi1-data74,
> > +                  xspi1-data30, xspi1-base, sdhc1-base, sdhc1-dir,
> > +                  sdhc2-data74, sdhc2-base, uart1-soutsin, uart1-rtscts,
> > +                  uart2-soutsin, uart2-rtscts, irq11-8, irq7-4, irq3-0,
> > +                  evt4-3, evt2-0, clk-out, asleep, reset-req ]
> 
> [Severity: Medium]
> Should clk-out also be listed in the function enum (with a corresponding
> if/then rule in allOf allowing the clk-out group)?
> 
> The other single-pad groups in RCWSR14 (asleep for ASLEEP_PMUX and
> reset-req for RESET_REQ_PMUX) expose their encoding 0 primary functions
> (asleep and reset-req) alongside their alternate functions.
> 
> For the clk-out group (CLK_OUT_PMUX in RCWSR14[5:3]), the schema permits
> the gpio (0b001) and flextimer (0b010) functions in allOf, but omits the
> primary clk-out (0b000) function, which prevents a board from selecting or
> restoring the CLK_OUT function via pinctrl states without failing schema
> validation.

No: the LX2160 doc states that CLK_OUT_PMUX 0b000 is reserved
and then it seems it dropped its CLK_OUT section (per the revision history).

> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20261103-for-upstream-lx2160a-rcw-pinmux-v1-v2-0-3aad0860b984@free.fr?part=1