Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Zhengping Zhang <zhengping.zhang@airoha.com>
To: Linus Walleij <linusw@kernel.org>,
	Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
Cc: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
	<lorenzo@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <brgl@kernel.org>, <naseefkm@gmail.com>,
	<benjamin.larsson@genexis.eu>, <linux-gpio@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>, <lei.dong@airoha.com>,
	<ansuelsmth@gmail.com>
Subject: Re: [PATCH 00/12] pinctrl: airoha: configure GPIO muxes explicitly and fix pad mappings
Date: Fri, 20 Nov 2026 14:39:24 +0800	[thread overview]
Message-ID: <av_rHJ5W-mq3UAZ3@mediatek.com> (raw)
In-Reply-To: <CAD++jL=_q3SWsh6AW6PLOC=h-z-h-N8AcC8SRCPVKsbzEPktfg@mail.gmail.com>

Hi Mikhail and Linux,

Thanks for the feedback. I investigated the formatting issues on my
side, but have not yet been able to reproduce the problem.

I sent this series using git-send-email 2.43.0, without manually
copying or pasting the patches into an email editor.

I also retrieved the series from lore using:

  b4 shazam 20261110094339.749110-1-zhengping.zhang@airoha.com

All 12 patches applied successfully on top of my local pinctrl/for-next
at bc843179e208a. I also checked the archived patch messages and found
no apparent encoding issues. I understand that these checks do not
rule out formatting problems in the copies you received.

Comparing the archived messages, I found that, for example, tabs are
preserved in the original patch 05/12 and in the quoted code in
Sashiko's reply:

Original:
https://lore.kernel.org/all/20261110094339.749110-6-zhengping.zhang@airoha.com/

Sashiko's reply:
https://lore.kernel.org/all/sashiko-outbox-206823@kernel.org/

However, the corresponding quoted code in Mikhail's reply has tabs
expanded to spaces:
https://lore.kernel.org/all/80e72b60-3128-4594-a4bf-bb184ffc754b@iopsys.eu/

I noticed that tabs are preserved in Mikhail's reply to Miquel's SPI
patch, so this does not appear to happen with every reply:
https://lore.kernel.org/all/37fc133b-a5f3-4b4d-ba2a-002239bbcebc@iopsys.eu/

Could you please share one affected incoming patch as a raw .eml
attachment, if possible? It would also help to know how you retrieved
or saved the patches, and wheter the formatting problems are visible
in the original message source. This would let me narrow down where
it changed.

Thanks for the suggestion to use b4. I will use it to manage subsequent
revisions, and will address the code review comments separately.

Thanks for your help tracking this down.

Best Regards,
Zhengping

On Wed, Nov 18, 2026 at 10:15:15PM +0100, Linus Walleij wrote:
> On Sun, Nov 15, 2026 at 3:10 PM Mikhail Kshevetskiy
> <mikhail.kshevetskiy@iopsys.eu> wrote:
> 
> > Hello Zhengping Zhang,
> >
> > Please fix your patches. Looks like you insert patches to the e-mail body,
> > thus your patches were converted to "mail encoding"
> > * tabs was replaced by spaces
> > * unchanged empty lines "<space>\n" were converted to just "\n"
> > * long lines were split with "=\n"
> > * "=" were replaced with "=3D"
> >
> > and so on. So please use "git send-email" for patch sending.
> 
> I agree, I can't work with this, maybe review a little.
> 
> If possible use the b4 tool to manage your patch set(s).
> 
> Yours,
> Linus Walleij

      reply	other threads:[~2026-11-20  6:39 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  9:43 [PATCH 00/12] pinctrl: airoha: configure GPIO muxes explicitly and fix pad mappings Zhengping Zhang
2026-11-10  9:43 ` [PATCH 01/12] pinctrl: airoha: fix setting of GPIO direction Zhengping Zhang
2026-11-10  9:53   ` sashiko-bot
2026-11-10  9:43 ` [PATCH 02/12] pinctrl: airoha: configure pin muxes on GPIO requests Zhengping Zhang
2026-11-10 10:14   ` sashiko-bot
2026-11-10  9:43 ` [PATCH 03/12] dt-bindings: pinctrl: airoha: describe all EN7581 GPIO mux groups Zhengping Zhang
2026-11-15 14:00   ` Mikhail Kshevetskiy
2026-11-10  9:43 ` [PATCH 04/12] pinctrl: airoha: an7581: fix PHY LED GPIO group assignments Zhengping Zhang
2026-11-15 14:02   ` Mikhail Kshevetskiy
2026-11-20  7:03     ` Zhengping Zhang
2026-11-10  9:43 ` [PATCH 05/12] pinctrl: airoha: an7581: select force GPIO mode on GPIO requests Zhengping Zhang
2026-11-10 10:00   ` sashiko-bot
2026-11-15 14:21   ` Mikhail Kshevetskiy
2026-11-20  7:19     ` Zhengping Zhang
2026-11-10  9:43 ` [PATCH 06/12] dt-bindings: pinctrl: airoha: describe all AN7583 GPIO mux groups Zhengping Zhang
2026-11-10  9:43 ` [PATCH 07/12] pinctrl: airoha: an7583: fix SPI pin mux config Zhengping Zhang
2026-11-10  9:43 ` [PATCH 08/12] pinctrl: airoha: an7583: fix eMMC " Zhengping Zhang
2026-11-10  9:43 ` [PATCH 09/12] pinctrl: airoha: an7583: use force GPIO mode for GPIO requests Zhengping Zhang
2026-11-10  9:56   ` sashiko-bot
2026-11-15 14:23   ` Mikhail Kshevetskiy
2026-11-10  9:43 ` [PATCH 10/12] dt-bindings: pinctrl: airoha: describe all EN7523 GPIO mux groups Zhengping Zhang
2026-11-10  9:43 ` [PATCH 11/12] pinctrl: airoha: en7523: use force GPIO mode for GPIO requests Zhengping Zhang
2026-11-15 14:24   ` Mikhail Kshevetskiy
2026-11-10  9:43 ` [PATCH 12/12] MAINTAINERS: add myself as Airoha pinctrl co-maintainer Zhengping Zhang
2026-11-15 14:09 ` [PATCH 00/12] pinctrl: airoha: configure GPIO muxes explicitly and fix pad mappings Mikhail Kshevetskiy
2026-11-18 21:15   ` Linus Walleij
2026-11-20  6:39     ` Zhengping Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av_rHJ5W-mq3UAZ3@mediatek.com \
    --to=zhengping.zhang@airoha.com \
    --cc=ansuelsmth@gmail.com \
    --cc=benjamin.larsson@genexis.eu \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lei.dong@airoha.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lorenzo@kernel.org \
    --cc=mikhail.kshevetskiy@iopsys.eu \
    --cc=naseefkm@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox