From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.42 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794757267; b=wW94bxGxS4EM9Tk7tPjrwNEgVY/OOa8QbM5ylJsKSvD47WHRqFhykOgvlZXRBePV66jp OIO7ciNXyHH3iqmL45uAfUz3qkJtPA0+vpgk+nP8ztJYT0Oly2X3L51un3qtevmrWNysA 2R3ON0CRhFcvYQDdnwsQTeYHnoHgr5HhVvOqzDjX+neUHwU05eyXtzpJ8+lsK8sD/50mM OZwAgmd3gh6IgZpeFRXouksymYw9oj+rQQH1RsYQhypQhTp7qvfVqYtmbhqHABLc8ksQ1 GwDuZksRKW9SnAspqvl1jikHz1/U6AqmHrhtyx7KGZnPcnAyMW+SO/uXuIXzi3oRLqg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794757267; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=PVuohZ8xLFR5YiCoEYGFhyPTULZBGZj7Wpwh1r3TICY=; b=vl4JpuRq/l1z2DBLsSmWPwpXYLhVFTPJrRF2jVueb601fWTzktUehvOd5SLmp424onLA x8s4tfCRhshgdIIDRAxB0FNotis8j6ksYj6ZssOD6rh8rSATxAUp/+5cfuivFwOBoAlWV R1zFInE/qFgTigD25KaEsF6tgUgKhDMZBe4subWz6ZrAiJjloSgTXazJJk1bi4b3dmzMF l0SvNAsaBeB8AVlfMq7EA+fzHUnUrcW75bR3edj34VDKU4Y4luWMBKt/Yw7FN4jKfePqr msGzEGAytj+kOzsdoqdc4Ap5UNBWAySHIq2gi2AQrzyfbrBy0O+IRJm2qJ1Mb7SpQfQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=JcnXBjQ6; arc=none smtp.remote-ip=209.85.221.42 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D213C606A327 for ; Sun, 15 Nov 2026 15:41:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D213C606A327 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=JcnXBjQ6 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-48e09aa5264so1172429f8f.2 for ; Sun, 15 Nov 2026 07:41:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1794757264; x=1795362064; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=PVuohZ8xLFR5YiCoEYGFhyPTULZBGZj7Wpwh1r3TICY=; b=JcnXBjQ6oVs3WO6WxsJjlXF3Srfn+XWnPXlN0yzPpJsvcbjAwiYznR2yVsrq+dIF0J W9K1hDH1dg4Rq7lZSMIhfD3gchU0KLGorPdGJ+zlQeEucdr7nNce45CvydySUCY90PWY Xyu/qB9TRVQV4d6tUrWZIxOCTwwDWe69IsTtjWCZjxdP2vvALjzMAogu8SPoZHkOZyaF zuC9NuaXKcHS/ydQMct1JDP/0pjhpMGbTARWR/YcAz+Qib3t24DwWdP7jNV5O7sXEqo0 nlPhnW30vWk79ZmVTGvnuZbrJ2Vgh12vhrZe5Vz+JkN4iiK2dMUW8v2WdxiY8cHNmbsu Y4BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794757264; x=1795362064; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PVuohZ8xLFR5YiCoEYGFhyPTULZBGZj7Wpwh1r3TICY=; b=wlpEU9aUZ02hs+Ou9Yg5AspPuz8fCjexCr4Y/9MGsjPEvOiBzyXBrvhoRNKrKWQulh wZrFGBUPD/6VCvFEvBbJO8+/gDuJkx4HzOpDSkgId6LWnOL0KBOZc3fopCb9YjgEMIAv hUOMshnAp6TaDiJeTu9q+BiSruMp7n/yHKyjGJxkj1rF/GhNHbTQP2LejNfrzc692pTk E3gVwvMQDjSfZMITGhuvhmu49p+f37MyDIQTocEeufsSQsj/4ZlpDyzx3lhzzRAIhje5 2J3+FHt3KAZI0VoGoxeMOX4/waQX6g+Fi3CEkC+6eXrlWd/XFCMcg5wbZ7b/pKxwcu3R 3Dhw== X-Forwarded-Encrypted: i=1; AL+hErE9J5s04rK8Ifu8Wt4dLaPW40JH3puWyV2MqxjogLMD4lM3T5qK1FhvL4bBnM8DIHsEas5KMfcc82XL@vger.kernel.org X-Gm-Message-State: APuU4Z8Ow5W39iXEvUvyOwCtlDkSlwyKL92uVvaFyPpD9XCoCMcRRc4+ 910rwF0bu6vD/+439HPR4bP2Nrjyzfap1QEsrQHOgXZnYDd2AWHcA6OsaZC9SxZQs2o= X-Gm-Gg: AYBFou0SJxnKEWbdvJBJ8tDoVMcaVphXTWFtFJBg92PseVprcsb61GOfANGnFVOmuGH l6fDiYSR/8t2IYU8No5zWv75n+ApXMcwrVEUHXZRclHtRt3D0aJZc0er5VrOv6b3hyX02QV/Mh7 nA1tnA7JB+An3KUlMe3aYNLeVIN+BobwEzc4N11OonNzh2znDg1xJa2RtxJac5v9p+KFJ9caxwp Py59ZLuNt+CwnrRZnfw70i465N7Igs5ZZxgy2SJqkJTAZRagRcDCSnMTzOJNTs6k0rh2/SJagG5 1icMe9NRbNLW4cdLzBYvwxvExg7uas9wMuetydwEKsgDr4714wru9ipOJjTG2iTHy836cpfPEQZ x0wVhXQgSUtRNqOgLrfUQfI6qFXq9+rXWirrXKNvanYQq+qZbD8nCmT2ASpBzvAkxvTxF4XouYy GQcU/yp/eXdZCICpa8d67vz3MGX4SlURdIJB6vZIewwSOMXU19c/ewOKbs8eOFUGWDrTfiAPC1h Vg+7wh15TAZbqV7k81U12Chejz/NhGg+j71H//H9IR4w7ji1diS1Os6aebNj+53MqrCIJX5+sjt j+Yx1nUHfm8pTgAii1q3F07coZUvCWJsdgM= X-Received: by 2002:a05:6000:2c04:b0:48e:d36:77 with SMTP id ffacd0b85a97d-49c6fc9db5bmr19465481f8f.4.1794757264141; Sun, 15 Nov 2026 07:41:04 -0800 (PST) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-49c888b90d4sm16462060f8f.9.2026.11.15.07.41.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Nov 2026 07:41:03 -0800 (PST) Date: Sun, 15 Nov 2026 16:41:01 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: gaohan@iscas.ac.cn Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guo Ren , Thomas Gleixner , Radu Rendec , Samuel Holland , Daniel Lezcano , Anup Patel , Stephen Boyd , Brian Masney , Jerome Brunet , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Philipp Zabel , Alexandre Belloni , Maxime Ripard , Linus Walleij , Andre Przywara , Han Gao , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , Conor Dooley , devicetree@vger.kernel.org, linux-csky@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 14/19] pinctrl: sunxi: add support for the Allwinner V861 PIO Message-ID: References: <20261114-v861-v1-0-eb71ec3ee523@iscas.ac.cn> <20261114-v861-v1-14-eb71ec3ee523@iscas.ac.cn> X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fgskattfdxvvv7hb" Content-Disposition: inline In-Reply-To: <20261114-v861-v1-14-eb71ec3ee523@iscas.ac.cn> --fgskattfdxvvv7hb Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH 14/19] pinctrl: sunxi: add support for the Allwinner V861 PIO MIME-Version: 1.0 Hello, On Sat, Nov 14, 2026 at 06:33:40AM +0800, Han Gao via B4 Relay wrote: > new file mode 100644 > index 000000000000..742465076d86 > --- /dev/null > +++ b/drivers/pinctrl/sunxi/pinctrl-sun252i-v861.c > @@ -0,0 +1,49 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Allwinner V861 SoC pinctrl driver. > + * > + * Copyright (c) 2026 Han Gao > + */ > + > +#include Don't include . already provides of_device_id with less dependencies, so please just drop including . > +#include > +#include > + > [...] > +static const struct of_device_id v861_pinctrl_match[] = { > + { .compatible = "allwinner,sun252i-v861-pinctrl", }, > + {} > +}; Please drop the comma before the closing } and add a space in the list terminator. Best regards Uwe --fgskattfdxvvv7hb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmr50okACgkQj4D7WH0S /k78BwgAggANSfiR3lIax5U5QxcHapAeEwjkuu5kUUd7ThVymu6geBziPkTKM9LN kV1vp14gkKuMuThllE6yPhDE+jBai3H2dmZPRAVxRmkHkRXaCGvN2Qy6QvjG7hn+ pKrIhNm9FD3gtJcf3syW5npYiRAxG/6TkK+Gz1PXPgmg9Yj7puOzJ5ZZsZ+kBOcS xiSHHn5ujqEIP4jnBc7Dv7UpeDH4NxdbQ6ssuWEYpdmNKvGpbP4Xi4tlxo4RAMXF XWXJcAtussx3dylMOghSQ5VBKABwOqksAb/tX5/oaY13ScR8Lg/M3WzfjwXPwvtR yRXJHXEAk7lxYPB9WoXGrz3bVWm0dg== =Eo1Y -----END PGP SIGNATURE----- --fgskattfdxvvv7hb--