From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Zhu Jun <zhujun2@cmss.chinamobile.com>
Cc: brgl@kernel.org, warthog618@gmail.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools: gpio-watch: Preserve line event read errors
Date: Fri, 20 Nov 2026 11:47:09 +0200 [thread overview]
Message-ID: <awAXHXfe8Lc09f3X@ashevche-desk.local> (raw)
In-Reply-To: <20261120061836.98108-1-zhujun2@cmss.chinamobile.com>
On Fri, Nov 20, 2026 at 02:18:36PM +0800, Zhu Jun wrote:
> The short-read check sets errno to EIO even when read() returns -1,
> hiding errors such as EINTR. Set EIO only for a nonnegative short
> read and keep the original errno for a failed read.
Isn't somebody sent similar change a week ago?
Before sending something like this, always check mailing list archive.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-11-20 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 6:18 [PATCH] tools: gpio-watch: Preserve line event read errors Zhu Jun
2026-11-20 9:47 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awAXHXfe8Lc09f3X@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox