From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Timur Tabi <timur@kernel.org>, Stephen Boyd <swboyd@chromium.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/3] gpiolib: Show correct direction from the beginning
Date: Fri, 5 Oct 2018 08:18:59 -0600 [thread overview]
Message-ID: <b020854a-819e-a0b4-5e29-a2aca19fad59@codeaurora.org> (raw)
In-Reply-To: <CAPybu_1qqdffE4K2BonCV0X_eYY+or6NSK9Bbco9A68N9aasVw@mail.gmail.com>
On 10/5/2018 12:52 AM, Ricardo Ribalda Delgado wrote:
> Hi
> On Fri, Oct 5, 2018 at 12:26 AM Jeffrey Hugo <jhugo@codeaurora.org> wrote:
>>
>> On 10/2/2018 9:21 AM, Jeffrey Hugo wrote:
>>> On 10/2/2018 8:08 AM, Ricardo Ribalda Delgado wrote:
>>>> Current code assumes that the direction is input if direction_input
>>>> function is set.
>>>> This might not be the case on GPIOs with programmable direction.
>>>>
>>>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>>>
>>> I'll try to get this series tested on QDF2400 by the end of the week.
>>
>> 1-2/3 (v3) and 3/3 (v4) still fails. Same issue. Attempting to access
>> config registers for GPIO 0 when the OS is not allowed to do that.
>>
>
> I think that I might found the bug. if gpio-reserved-ranges was
> present the initialization was lost.
>
> Can you try with v5
>
> Thanks for your help
I'll let you know how it goes.
--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
prev parent reply other threads:[~2018-10-05 14:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 14:08 [PATCH v4 3/3] gpiolib: Show correct direction from the beginning Ricardo Ribalda Delgado
2018-10-02 15:21 ` Jeffrey Hugo
2018-10-04 22:26 ` Jeffrey Hugo
2018-10-05 6:52 ` Ricardo Ribalda Delgado
2018-10-05 14:18 ` Jeffrey Hugo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b020854a-819e-a0b4-5e29-a2aca19fad59@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
--cc=swboyd@chromium.org \
--cc=timur@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).