* [PATCH] dt-bindings: pinctrl: renesas,rza2-pinctrl: Fix pin controller node name
@ 2020-08-21 11:11 Geert Uytterhoeven
2020-08-21 15:27 ` Sergei Shtylyov
2020-09-08 20:52 ` Rob Herring
0 siblings, 2 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-08-21 11:11 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Chris Brandt
Cc: linux-renesas-soc, linux-gpio, devicetree, Geert Uytterhoeven
According to Devicetree Specification v0.2 and later, Section "Generic
Names Recommendation", the node name for a pin controller device node
should be "pinctrl".
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
To be queued in sh-pfc for v5.10.
.../devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml
index b7911a994f3a9f12..ce1f7343788faeff 100644
--- a/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml
@@ -84,7 +84,7 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/pinctrl/r7s9210-pinctrl.h>
- pinctrl: pin-controller@fcffe000 {
+ pinctrl: pinctrl@fcffe000 {
compatible = "renesas,r7s9210-pinctrl";
reg = <0xfcffe000 0x1000>;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: pinctrl: renesas,rza2-pinctrl: Fix pin controller node name
2020-08-21 11:11 [PATCH] dt-bindings: pinctrl: renesas,rza2-pinctrl: Fix pin controller node name Geert Uytterhoeven
@ 2020-08-21 15:27 ` Sergei Shtylyov
2020-08-21 17:41 ` Geert Uytterhoeven
2020-08-28 9:37 ` Linus Walleij
2020-09-08 20:52 ` Rob Herring
1 sibling, 2 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2020-08-21 15:27 UTC (permalink / raw)
To: Geert Uytterhoeven, Linus Walleij, Rob Herring, Chris Brandt
Cc: linux-renesas-soc, linux-gpio, devicetree
Hello!
On 8/21/20 2:11 PM, Geert Uytterhoeven wrote:
> According to Devicetree Specification v0.2 and later, Section "Generic
> Names Recommendation", the node name for a pin controller device node
> should be "pinctrl".
Ugh, what a lame name! :-(
And they say DT should be OS agnostic...
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
I think more DTs have "pin-controler".
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: renesas,rza2-pinctrl: Fix pin controller node name
2020-08-21 15:27 ` Sergei Shtylyov
@ 2020-08-21 17:41 ` Geert Uytterhoeven
2020-08-23 9:00 ` Sergei Shtylyov
2020-08-28 9:37 ` Linus Walleij
1 sibling, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-08-21 17:41 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Linus Walleij, Rob Herring, Chris Brandt, Linux-Renesas,
open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hi Sergei,
On Fri, Aug 21, 2020 at 5:27 PM Sergei Shtylyov
<sergei.shtylyov@gmail.com> wrote:
> On 8/21/20 2:11 PM, Geert Uytterhoeven wrote:
> > According to Devicetree Specification v0.2 and later, Section "Generic
> > Names Recommendation", the node name for a pin controller device node
> > should be "pinctrl".
>
> Ugh, what a lame name! :-(
> And they say DT should be OS agnostic...
>
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> I think more DTs have "pin-controler".
I was surprised to discover the opposite, too:
$ git grep "\<pinctrl@" v5.9-rc1 | wc -l
335
$ git grep "\<pin-controller@" v5.9-rc1 | wc -l
102
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: pinctrl: renesas,rza2-pinctrl: Fix pin controller node name
2020-08-21 17:41 ` Geert Uytterhoeven
@ 2020-08-23 9:00 ` Sergei Shtylyov
0 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2020-08-23 9:00 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linus Walleij, Rob Herring, Chris Brandt, Linux-Renesas,
open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On 21.08.2020 20:41, Geert Uytterhoeven wrote:
>> On 8/21/20 2:11 PM, Geert Uytterhoeven wrote:
>>> According to Devicetree Specification v0.2 and later, Section "Generic
>>> Names Recommendation", the node name for a pin controller device node
>>> should be "pinctrl".
>>
>> Ugh, what a lame name! :-(
>> And they say DT should be OS agnostic...
>>
>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>
>> I think more DTs have "pin-controler".
>
> I was surprised to discover the opposite, too:
>
> $ git grep "\<pinctrl@" v5.9-rc1 | wc -l
> 335
> $ git grep "\<pin-controller@" v5.9-rc1 | wc -l
> 102
Sorry, I was probably thinking that I was replying to a DT patch, not the
bindings patch, hence this comment (it only meant Renesas DTs). It doesn't
really surprise me that more DTs overall have "pinctrl", sigh...
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: renesas,rza2-pinctrl: Fix pin controller node name
2020-08-21 15:27 ` Sergei Shtylyov
2020-08-21 17:41 ` Geert Uytterhoeven
@ 2020-08-28 9:37 ` Linus Walleij
1 sibling, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2020-08-28 9:37 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Geert Uytterhoeven, Rob Herring, Chris Brandt, Linux-Renesas,
open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Fri, Aug 21, 2020 at 5:27 PM Sergei Shtylyov
<sergei.shtylyov@gmail.com> wrote:
> On 8/21/20 2:11 PM, Geert Uytterhoeven wrote:
>
> > According to Devicetree Specification v0.2 and later, Section "Generic
> > Names Recommendation", the node name for a pin controller device node
> > should be "pinctrl".
>
> Ugh, what a lame name! :-(
> And they say DT should be OS agnostic...
Ha ha. :D
The device tree standardization is driven with the bureaucratic ambition to
be generic, predictable and non-personal. Mimicing the characteristic of
the impersonal objects in life, such as the planets, or the plants.
This is just an ambition, in reality the people doing it are Linux-heads.
We (the DT community) try to be better people, we just fail regularly.
That is OK, the important thing is to know one can and should do better.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: renesas,rza2-pinctrl: Fix pin controller node name
2020-08-21 11:11 [PATCH] dt-bindings: pinctrl: renesas,rza2-pinctrl: Fix pin controller node name Geert Uytterhoeven
2020-08-21 15:27 ` Sergei Shtylyov
@ 2020-09-08 20:52 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2020-09-08 20:52 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rob Herring, devicetree, linux-gpio, Chris Brandt,
linux-renesas-soc, Linus Walleij
On Fri, 21 Aug 2020 13:11:27 +0200, Geert Uytterhoeven wrote:
> According to Devicetree Specification v0.2 and later, Section "Generic
> Names Recommendation", the node name for a pin controller device node
> should be "pinctrl".
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> To be queued in sh-pfc for v5.10.
>
> .../devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-08 20:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-21 11:11 [PATCH] dt-bindings: pinctrl: renesas,rza2-pinctrl: Fix pin controller node name Geert Uytterhoeven
2020-08-21 15:27 ` Sergei Shtylyov
2020-08-21 17:41 ` Geert Uytterhoeven
2020-08-23 9:00 ` Sergei Shtylyov
2020-08-28 9:37 ` Linus Walleij
2020-09-08 20:52 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).