From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Subject: Re: [PATCH] pinctrl: samsung: Fix memory mapping code Date: Wed, 22 Feb 2017 08:59:33 +0100 Message-ID: References: <1487749442-23806-1-git-send-email-a.hajda@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1487749442-23806-1-git-send-email-a.hajda@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Andrzej Hajda , Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Linus Walleij , linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz List-Id: linux-gpio@vger.kernel.org Hi, On 2017-02-22 08:44, Andrzej Hajda wrote: > Some pinctrls share memory regions, and devm_ioremap_resource does not > allow to share resources, in opposition to devm_ioremap. > This patch restores back usage of devm_ioremap function, but with proper > error handling and logging. > > Fixes: baafaca ("pinctrl: samsung: Fix return value check in samsung_pinctrl_get_soc_data()") > Signed-off-by: Andrzej Hajda Tested-by: Marek Szyprowski > --- > drivers/pinctrl/samsung/pinctrl-samsung.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c > index f9ddba7..ebecff8 100644 > --- a/drivers/pinctrl/samsung/pinctrl-samsung.c > +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c > @@ -988,9 +988,12 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d, > > for (i = 0; i < ctrl->nr_ext_resources + 1; i++) { > res = platform_get_resource(pdev, IORESOURCE_MEM, i); > - virt_base[i] = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(virt_base[i])) > - return ERR_CAST(virt_base[i]); > + virt_base[i] = devm_ioremap(&pdev->dev, res->start, > + resource_size(res)); > + if (!virt_base[i]) { > + dev_err(&pdev->dev, "failed to ioremap %pR\n", res); > + return ERR_PTR(-EIO); > + } > } > > bank = d->pin_banks; Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland