From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75A5C139CE4; Tue, 23 Apr 2024 13:48:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713880081; cv=none; b=UPIx0CG9uHQ4D7rauJxE4pf52RoPW0zshuWUA1BWPTRhU1iFZzO+SEo8z1j87ASpCm2nBZZw5HgPLnsz+O7myFDTcf0DruZQ5jGxhLx0zyiawrdAVwc/TxFeJLgAAn8vSX1Cz5L6hOgaZ9vY66ktI8HZmDz8r01A+o1j2RI8VtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713880081; c=relaxed/simple; bh=y7Dn96ugvzlC/fk+MWurHAoRm3fMDnGgcPR8W5+vqVk=; h=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=UZGi0raQE83vfIIdXzhjix6h2EHLYfQIlu874A0fqgf2u/y0uem7UZ3gz2t+iSVbhnsh02quo8mviO5SdgtRVby2A7OYP3xrwUawCu7h5YXC5mwuVYkAHTnoIRpZd8P2sRpTB09B7RXkW5sVkMhA10lQwwJ5odYwCy6pwtcpSh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YXMcclPS; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YXMcclPS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713880081; x=1745416081; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=y7Dn96ugvzlC/fk+MWurHAoRm3fMDnGgcPR8W5+vqVk=; b=YXMcclPSjxK2/3aCS5GMtdKaPQ2j/KxxdMYUb7OkCcHqt+t7kH3lnJa9 QrtzH08rDpzEbv3SnuEAUIwHTKvLC7jX1cU2xPD9FOWYhBA85g1AZVvY6 lKLarmnzuZDJNMyfwTiCKiTiraawz6TwYMPgSznC2y6EXQSc8Bn3p4cwB LgvLLTUf4+FY9pfBU0xuGlEzY31gM49gut183EqCmZfXZ6m5K+QyvK6Se nLuFuamctWkwOmEeIBsjbiqY56QL+1ya9JgHT6znTggIJCNgbqd7/JSpg 8wLZ/Xo668jK4UfPlIm1lVnS/XHSksnPsQC53bWzHDrS5KJiseJz7Kvr7 g==; X-CSE-ConnectionGUID: zpPTa7NCRbe1esiX4IPBiA== X-CSE-MsgGUID: XM8UpB/FSpy8JUoIi7fGVw== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="13296914" X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="13296914" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 06:48:00 -0700 X-CSE-ConnectionGUID: BkcXkZPRS0S3k78O4PCmZQ== X-CSE-MsgGUID: U3NDdzEdTHSANk8ap3Fl9Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="24881235" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.245.247.40]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 06:47:57 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Tue, 23 Apr 2024 16:47:53 +0300 (EEST) To: Aapo Vienamo cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Mika Westerberg , Andy Shevchenko Subject: Re: [PATCH] gpio: Add Intel Granite Rapids-D vGPIO driver In-Reply-To: <20240419080555.97343-1-aapo.vienamo@linux.intel.com> Message-ID: References: <20240419080555.97343-1-aapo.vienamo@linux.intel.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 19 Apr 2024, Aapo Vienamo wrote: > This driver provides a basic GPIO driver for the Intel Granite Rapids-D > virtual GPIOs. On SoCs with limited physical pins on the package, the > physical pins controlled by this driver would be exposed on an external > device such as a BMC or CPLD. > > Signed-off-by: Aapo Vienamo > Reviewed-by: Mika Westerberg > Signed-off-by: Andy Shevchenko > diff --git a/drivers/gpio/gpio-graniterapids.c b/drivers/gpio/gpio-graniterapids.c > new file mode 100644 > index 000000000000..61bcafe1985e > --- /dev/null > +++ b/drivers/gpio/gpio-graniterapids.c > @@ -0,0 +1,382 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Intel Granite Rapids-D vGPIO driver > + * > + * Copyright (c) 2024, Intel Corporation. > + * > + * Author: Aapo Vienamo > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +#define GNR_NUM_PINS 128 > +#define GNR_PINS_PER_REG 32 > +#define GNR_NUM_REGS DIV_ROUND_UP(GNR_NUM_PINS, GNR_PINS_PER_REG) > + > +#define GNR_CFG_BAR 0x00 > +#define GNR_CFG_LOCK_OFFSET 0x04 > +#define GNR_GPI_STATUS_OFFSET 0x20 > +#define GNR_GPI_ENABLE_OFFSET 0x24 > + > +#define GNR_CFG_DW_RX_MASK (3 << 22) GENMASK() + #include > +#define GNR_CFG_DW_RX_DISABLE (2 << 22) > +#define GNR_CFG_DW_RX_EDGE (1 << 22) > +#define GNR_CFG_DW_RX_LEVEL (0 << 22) FIELD_PREP(GNR_CFG_DW_RX_MASK, xx) x 3 > +#define GNR_CFG_DW_RXDIS BIT(4) > +#define GNR_CFG_DW_TXDIS BIT(3) > +#define GNR_CFG_DW_RXSTATE BIT(1) > +#define GNR_CFG_DW_TXSTATE BIT(0) These require #include (just pointing this out so you know in future, you'll need to add it anyway for GENMASK() as mentioned above). -- i.