From: Jan Kiszka <jan.kiszka@siemens.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Sascha Weisenberger <sascha.weisenberger@siemens.com>
Subject: Re: [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent PCI device
Date: Fri, 9 Jun 2017 09:44:28 +0200 [thread overview]
Message-ID: <b52e2c46-05db-63fa-f0a5-b59ca73e6e3e@siemens.com> (raw)
In-Reply-To: <CACRpkdah8Bgo2Ga5RK8+9=dqr0pizSYd50wqQk++TyycW6=xnQ@mail.gmail.com>
On 2017-06-09 09:21, Linus Walleij wrote:
> On Fri, Jun 2, 2017 at 9:28 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
>> This fixes reloading of the GPIO driver for the same platform device
>> instance as created by the exar UART driver: First of all, the driver
>> sets drvdata to its own value during probing and does not restore the
>> original value on exit. But this won't help anyway as the core clears
>> drvdata after the driver left.
>>
>> Set the platform device parent instead.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> If I get Gregs ACK on this I can merge patches 2-11 through the
> GPIO tree.
>
Patch 10 needs an update, Andy had remarks. I need to resync and send it
- there will be v6 soon.
Thanks,
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2017-06-09 7:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 7:28 [PATCH v5 00/11] serial/gpio: exar: Fixes and support for IOT2000 Jan Kiszka
2017-06-02 7:28 ` [PATCH v5 01/11] serial: exar: Leave MPIOs as output for Commtech adapters Jan Kiszka
2017-06-09 7:20 ` Linus Walleij
2017-06-09 8:29 ` Greg Kroah-Hartman
2017-06-02 7:28 ` [PATCH v5 02/11] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards Jan Kiszka
2017-06-02 7:28 ` [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent PCI device Jan Kiszka
2017-06-09 7:21 ` Linus Walleij
2017-06-09 7:44 ` Jan Kiszka [this message]
2017-06-09 8:29 ` Greg Kroah-Hartman
2017-06-02 7:28 ` [PATCH v5 04/11] gpio: exar: Allocate resources on behalf of the platform device Jan Kiszka
2017-06-02 7:28 ` [PATCH v5 05/11] gpio: exar: Fix iomap request Jan Kiszka
2017-06-02 7:28 ` [PATCH v5 06/11] gpio: exar: Fix reading of directions and values Jan Kiszka
2017-06-02 7:28 ` [PATCH v5 07/11] gpio-exar/8250-exar: Rearrange gpiochip parenthood Jan Kiszka
2017-06-02 7:28 ` [PATCH v5 08/11] serial: exar: Factor out platform hooks Jan Kiszka
2017-06-02 7:28 ` [PATCH v5 09/11] platform: Accept const properties Jan Kiszka
2017-06-02 7:28 ` [PATCH v5 10/11] gpio-exar/8250-exar: Make set of exported GPIOs configurable Jan Kiszka
2017-06-02 10:32 ` Andy Shevchenko
2017-06-02 7:28 ` [PATCH v5 11/11] serial: exar: Add support for IOT2040 device Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b52e2c46-05db-63fa-f0a5-b59ca73e6e3e@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=andy.shevchenko@gmail.com \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sascha.weisenberger@siemens.com \
--cc=sudip.mukherjee@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).