* [PATCH] gpio: aspeed: fix the GPIO number passed to pinctrl_gpio_set_config()
@ 2023-10-03 7:39 Bartosz Golaszewski
2023-10-03 8:54 ` Andy Shevchenko
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2023-10-03 7:39 UTC (permalink / raw)
To: Linus Walleij, Andy Shevchenko, Joel Stanley, Andrew Jeffery
Cc: linux-gpio, linux-arm-kernel, linux-aspeed, linux-kernel,
Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
pinctrl_gpio_set_config() expects the GPIO number from the global GPIO
numberspace, not the controller-relative offset, which needs to be added
to the chip base.
Fixes: 5ae4cb94b313 ("gpio: aspeed: Add debounce support")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/gpio/gpio-aspeed.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index da33bbbdacb9..58f107194fda 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -973,7 +973,7 @@ static int aspeed_gpio_set_config(struct gpio_chip *chip, unsigned int offset,
else if (param == PIN_CONFIG_BIAS_DISABLE ||
param == PIN_CONFIG_BIAS_PULL_DOWN ||
param == PIN_CONFIG_DRIVE_STRENGTH)
- return pinctrl_gpio_set_config(offset, config);
+ return pinctrl_gpio_set_config(chip->base + offset, config);
else if (param == PIN_CONFIG_DRIVE_OPEN_DRAIN ||
param == PIN_CONFIG_DRIVE_OPEN_SOURCE)
/* Return -ENOTSUPP to trigger emulation, as per datasheet */
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: aspeed: fix the GPIO number passed to pinctrl_gpio_set_config()
2023-10-03 7:39 [PATCH] gpio: aspeed: fix the GPIO number passed to pinctrl_gpio_set_config() Bartosz Golaszewski
@ 2023-10-03 8:54 ` Andy Shevchenko
2023-10-05 1:12 ` Andrew Jeffery
2023-10-05 6:42 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2023-10-03 8:54 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Linus Walleij, Joel Stanley, Andrew Jeffery, linux-gpio,
linux-arm-kernel, linux-aspeed, linux-kernel, Bartosz Golaszewski
On Tue, Oct 03, 2023 at 09:39:26AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> pinctrl_gpio_set_config() expects the GPIO number from the global GPIO
> numberspace, not the controller-relative offset, which needs to be added
> to the chip base.
Right, because it has no clue what chip this offset is related to.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: aspeed: fix the GPIO number passed to pinctrl_gpio_set_config()
2023-10-03 7:39 [PATCH] gpio: aspeed: fix the GPIO number passed to pinctrl_gpio_set_config() Bartosz Golaszewski
2023-10-03 8:54 ` Andy Shevchenko
@ 2023-10-05 1:12 ` Andrew Jeffery
2023-10-05 6:42 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Jeffery @ 2023-10-05 1:12 UTC (permalink / raw)
To: Bartosz Golaszewski, Linus Walleij, Andy Shevchenko, Joel Stanley,
Andrew Jeffery
Cc: linux-gpio, linux-arm-kernel, linux-aspeed, linux-kernel,
Bartosz Golaszewski
On Tue, 2023-10-03 at 09:39 +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> pinctrl_gpio_set_config() expects the GPIO number from the global GPIO
> numberspace, not the controller-relative offset, which needs to be added
> to the chip base.
>
> Fixes: 5ae4cb94b313 ("gpio: aspeed: Add debounce support")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Thanks!
> ---
> drivers/gpio/gpio-aspeed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
> index da33bbbdacb9..58f107194fda 100644
> --- a/drivers/gpio/gpio-aspeed.c
> +++ b/drivers/gpio/gpio-aspeed.c
> @@ -973,7 +973,7 @@ static int aspeed_gpio_set_config(struct gpio_chip *chip, unsigned int offset,
> else if (param == PIN_CONFIG_BIAS_DISABLE ||
> param == PIN_CONFIG_BIAS_PULL_DOWN ||
> param == PIN_CONFIG_DRIVE_STRENGTH)
> - return pinctrl_gpio_set_config(offset, config);
> + return pinctrl_gpio_set_config(chip->base + offset, config);
> else if (param == PIN_CONFIG_DRIVE_OPEN_DRAIN ||
> param == PIN_CONFIG_DRIVE_OPEN_SOURCE)
> /* Return -ENOTSUPP to trigger emulation, as per datasheet */
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: aspeed: fix the GPIO number passed to pinctrl_gpio_set_config()
2023-10-03 7:39 [PATCH] gpio: aspeed: fix the GPIO number passed to pinctrl_gpio_set_config() Bartosz Golaszewski
2023-10-03 8:54 ` Andy Shevchenko
2023-10-05 1:12 ` Andrew Jeffery
@ 2023-10-05 6:42 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2023-10-05 6:42 UTC (permalink / raw)
To: Linus Walleij, Andy Shevchenko, Joel Stanley, Andrew Jeffery
Cc: linux-gpio, linux-arm-kernel, linux-aspeed, linux-kernel,
Bartosz Golaszewski
On Tue, Oct 3, 2023 at 9:39 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> pinctrl_gpio_set_config() expects the GPIO number from the global GPIO
> numberspace, not the controller-relative offset, which needs to be added
> to the chip base.
>
> Fixes: 5ae4cb94b313 ("gpio: aspeed: Add debounce support")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> drivers/gpio/gpio-aspeed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
> index da33bbbdacb9..58f107194fda 100644
> --- a/drivers/gpio/gpio-aspeed.c
> +++ b/drivers/gpio/gpio-aspeed.c
> @@ -973,7 +973,7 @@ static int aspeed_gpio_set_config(struct gpio_chip *chip, unsigned int offset,
> else if (param == PIN_CONFIG_BIAS_DISABLE ||
> param == PIN_CONFIG_BIAS_PULL_DOWN ||
> param == PIN_CONFIG_DRIVE_STRENGTH)
> - return pinctrl_gpio_set_config(offset, config);
> + return pinctrl_gpio_set_config(chip->base + offset, config);
> else if (param == PIN_CONFIG_DRIVE_OPEN_DRAIN ||
> param == PIN_CONFIG_DRIVE_OPEN_SOURCE)
> /* Return -ENOTSUPP to trigger emulation, as per datasheet */
> --
> 2.39.2
>
Queued for fixes.
Bart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-05 14:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-03 7:39 [PATCH] gpio: aspeed: fix the GPIO number passed to pinctrl_gpio_set_config() Bartosz Golaszewski
2023-10-03 8:54 ` Andy Shevchenko
2023-10-05 1:12 ` Andrew Jeffery
2023-10-05 6:42 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).