Re: [PATCH v2] gpio: provide lockdep keys for nested/unnested irqchips

[Grygorii Strashko <grygorii.strashko@ti.com>]

On 01/11/2017 09:43 AM, Linus Walleij wrote:
> The helper function for adding a GPIO chip compiles in a lockdep
> key for debugging, the same key is needed for nested chips as
> well.
>
> The macro construction is unreadable, replace this with two
> static inlines instead.
>
> The _gpiochip_irqchip_add prefixed function is not helpful,
> rename it with gpiochip_irqchip_add_key() that tell us what the
> function is actually doing.
>
> Fixes: d245b3f9bd36 ("gpio: simplify adding threaded interrupts")
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Cc: Clemens Gruber <clemens.gruber@pqgruber.com>
> Cc: Roger Quadros <rogerq@ti.com>
> Reported-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> Reported-by: Roger Quadros <rogerq@ti.com>
> Reported-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Write code that actually compiles on LOCKDEP too, now I've
>   had it with confusing _underscores.
> ---
>  drivers/gpio/gpiolib.c      | 18 ++++++------
>  include/linux/gpio/driver.h | 70 ++++++++++++++++++++++++++++++++-------------
>  2 files changed, 59 insertions(+), 29 deletions(-)
>

Tested-by: Grygorii Strashko <grygorii.strashko@ti.com>

regards,
-grygorii