From: Thor Thayer <thor.thayer@linux.intel.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-gpio@vger.kernel.org
Cc: "Grygorii Strashko" <grygorii.strashko@ti.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"William Breathitt Gray" <vilhelm.gray@gmail.com>,
"Ray Jui" <rjui@broadcom.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"David Cohen" <david.a.cohen@linux.intel.com>,
"Scott Branden" <sbranden@broadcom.com>,
linux-acpi@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Alexander Shiyan" <shc_work@mail.ru>,
"Michal Simek" <michal.simek@xilinx.com>,
"Kevin Hilman" <khilman@kernel.org>,
linux-tegra@vger.kernel.org, "Joel Stanley" <joel@jms.id.au>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h
Date: Tue, 1 Aug 2017 13:57:59 -0500 [thread overview]
Message-ID: <b79f450d-f4a7-003d-4542-b5d5e4ab4483@linux.intel.com> (raw)
In-Reply-To: <1499140415-31677-1-git-send-email-yamada.masahiro@socionext.com>
On 07/03/2017 10:53 PM, Masahiro Yamada wrote:
> Some of include directives in include/linux/gpio/driver.h are
> unneeded because the header does not need to know the content of
> struct device, irq_chip, etc. Just declare they are structures.
>
> On the other hand, <linux/irqhandler.h> and <linux/spinlock_types.h>
> turned out to be necessary for irq_flow_handler_t and spinlock_t,
> respectively.
>
> Each driver should include what it needs without relying on what is
> implicitly included from <linux/gpio/driver.h>. This will cut down
> unnecessary header parsing.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/gpio/gpio-altera-a10sr.c | 2 ++
> drivers/gpio/gpio-altera.c | 3 +++
For the Altera GPIO files:
Acked-by: Thor Thayer <thor.thayer@linux.intel.com>
prev parent reply other threads:[~2017-08-01 18:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 3:53 [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h Masahiro Yamada
2017-07-04 8:30 ` Charles Keepax
2017-07-04 12:58 ` William Breathitt Gray
2017-07-04 15:43 ` Masahiro Yamada
2017-07-04 15:51 ` Andy Shevchenko
[not found] ` <1499140415-31677-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2017-07-04 10:06 ` Andy Shevchenko
2017-07-04 10:39 ` Masahiro Yamada
[not found] ` <1499162760.22624.246.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-07-31 13:48 ` Linus Walleij
2017-07-31 14:04 ` Andy Shevchenko
2017-08-01 7:53 ` Linus Walleij
2017-08-01 11:04 ` Andy Shevchenko
2017-08-02 1:19 ` Masahiro Yamada
2017-07-06 6:13 ` kbuild test robot
2017-07-06 6:15 ` kbuild test robot
2017-08-01 18:57 ` Thor Thayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b79f450d-f4a7-003d-4542-b5d5e4ab4483@linux.intel.com \
--to=thor.thayer@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=david.a.cohen@linux.intel.com \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=joel@jms.id.au \
--cc=jonathanh@nvidia.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=shc_work@mail.ru \
--cc=soren.brinkmann@xilinx.com \
--cc=thierry.reding@gmail.com \
--cc=vilhelm.gray@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).