* linux-next: build failure after merge of the gpio-brgl tree
@ 2021-12-13 20:31 broonie
2021-12-14 3:12 ` Florian Fainelli
0 siblings, 1 reply; 4+ messages in thread
From: broonie @ 2021-12-13 20:31 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Florian Fainelli, Xiang wangx, Linux Kernel Mailing List,
Linux Next Mailing List, linux-gpio
Hi all,
After merging the gpio-brgl tree, today's linux-next build (x86_64
allmodconfig) failed like this:
/tmp/next/build/drivers/gpio/gpio-bcm-kona.c:508:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
508 | static const struct of_device_id const bcm_kona_gpio_of_match[] = {
| ^~~~~
cc1: all warnings being treated as errors
Caused by commit
19784a059cf47b ("gpio: bcm-kona: add const to of_device_id")
I used the tree from yesterday instead.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: build failure after merge of the gpio-brgl tree
2021-12-13 20:31 linux-next: build failure after merge of the gpio-brgl tree broonie
@ 2021-12-14 3:12 ` Florian Fainelli
2021-12-17 6:17 ` Stephen Rothwell
0 siblings, 1 reply; 4+ messages in thread
From: Florian Fainelli @ 2021-12-14 3:12 UTC (permalink / raw)
To: broonie, Bartosz Golaszewski
Cc: Xiang wangx, Linux Kernel Mailing List, Linux Next Mailing List,
linux-gpio
On 12/13/2021 12:31 PM, broonie@kernel.org wrote:
> Hi all,
>
> After merging the gpio-brgl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> /tmp/next/build/drivers/gpio/gpio-bcm-kona.c:508:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> 508 | static const struct of_device_id const bcm_kona_gpio_of_match[] = {
> | ^~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 19784a059cf47b ("gpio: bcm-kona: add const to of_device_id")
>
> I used the tree from yesterday instead.
Doh! Should have double checked the code as the diff was not giving
enough context. This patch should simply be dropped, not even build
tested by Xiang it seems.
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: build failure after merge of the gpio-brgl tree
2021-12-14 3:12 ` Florian Fainelli
@ 2021-12-17 6:17 ` Stephen Rothwell
2021-12-17 9:14 ` Bartosz Golaszewski
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2021-12-17 6:17 UTC (permalink / raw)
To: Florian Fainelli
Cc: broonie, Bartosz Golaszewski, Xiang wangx,
Linux Kernel Mailing List, Linux Next Mailing List, linux-gpio
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
Hi all,
On Mon, 13 Dec 2021 19:12:05 -0800 Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> On 12/13/2021 12:31 PM, broonie@kernel.org wrote:
> > Hi all,
> >
> > After merging the gpio-brgl tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > /tmp/next/build/drivers/gpio/gpio-bcm-kona.c:508:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> > 508 | static const struct of_device_id const bcm_kona_gpio_of_match[] = {
> > | ^~~~~
> > cc1: all warnings being treated as errors
> >
> > Caused by commit
> >
> > 19784a059cf47b ("gpio: bcm-kona: add const to of_device_id")
> >
> > I used the tree from yesterday instead.
>
> Doh! Should have double checked the code as the diff was not giving
> enough context. This patch should simply be dropped, not even build
> tested by Xiang it seems.
Today, I have reverted that commit. Please remove or revert it ASAP.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: build failure after merge of the gpio-brgl tree
2021-12-17 6:17 ` Stephen Rothwell
@ 2021-12-17 9:14 ` Bartosz Golaszewski
0 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2021-12-17 9:14 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Florian Fainelli, Mark Brown, Xiang wangx,
Linux Kernel Mailing List, Linux Next Mailing List,
open list:GPIO SUBSYSTEM
On Fri, Dec 17, 2021 at 7:17 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> On Mon, 13 Dec 2021 19:12:05 -0800 Florian Fainelli <f.fainelli@gmail.com> wrote:
> >
> > On 12/13/2021 12:31 PM, broonie@kernel.org wrote:
> > > Hi all,
> > >
> > > After merging the gpio-brgl tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > /tmp/next/build/drivers/gpio/gpio-bcm-kona.c:508:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> > > 508 | static const struct of_device_id const bcm_kona_gpio_of_match[] = {
> > > | ^~~~~
> > > cc1: all warnings being treated as errors
> > >
> > > Caused by commit
> > >
> > > 19784a059cf47b ("gpio: bcm-kona: add const to of_device_id")
> > >
> > > I used the tree from yesterday instead.
> >
> > Doh! Should have double checked the code as the diff was not giving
> > enough context. This patch should simply be dropped, not even build
> > tested by Xiang it seems.
>
> Today, I have reverted that commit. Please remove or revert it ASAP.
>
> --
> Cheers,
> Stephen Rothwell
Done, sorry for the delay.
Bartosz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-17 9:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-13 20:31 linux-next: build failure after merge of the gpio-brgl tree broonie
2021-12-14 3:12 ` Florian Fainelli
2021-12-17 6:17 ` Stephen Rothwell
2021-12-17 9:14 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).