From: claudiu beznea <claudiu.beznea@tuxon.dev>
To: Andrei Coardos <aboutphysycs@gmail.com>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: andy@kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org,
ludovic.desroches@microchip.com,
Alexandru Ardelean <alex@shruggie.ro>
Subject: Re: [PATCH] gpio: sama5d2-piobu: remove unneeded call to platform_set_drvdata()
Date: Wed, 2 Aug 2023 07:42:17 +0300 [thread overview]
Message-ID: <bdcffc0f-5bd7-d6e5-74a1-ae5f934af3ff@tuxon.dev> (raw)
In-Reply-To: <20230728182522.18477-1-aboutphysycs@gmail.com>
On 28.07.2023 21:25, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
> ---
> drivers/gpio/gpio-sama5d2-piobu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-sama5d2-piobu.c b/drivers/gpio/gpio-sama5d2-piobu.c
> index 767c33ae3213..d89da7300ddd 100644
> --- a/drivers/gpio/gpio-sama5d2-piobu.c
> +++ b/drivers/gpio/gpio-sama5d2-piobu.c
> @@ -189,7 +189,6 @@ static int sama5d2_piobu_probe(struct platform_device *pdev)
> if (!piobu)
> return -ENOMEM;
>
> - platform_set_drvdata(pdev, piobu);
> piobu->chip.label = pdev->name;
> piobu->chip.parent = &pdev->dev;
> piobu->chip.owner = THIS_MODULE,
prev parent reply other threads:[~2023-08-02 4:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 18:25 [PATCH] gpio: sama5d2-piobu: remove unneeded call to platform_set_drvdata() Andrei Coardos
2023-07-30 19:52 ` Andy Shevchenko
2023-08-01 19:28 ` Bartosz Golaszewski
2023-08-02 4:42 ` claudiu beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdcffc0f-5bd7-d6e5-74a1-ae5f934af3ff@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=aboutphysycs@gmail.com \
--cc=alex@shruggie.ro \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).