From: Sudeep Holla <sudeep.holla@arm.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org,
Alexandre Courbot <acourbot@nvidia.com>,
linux-arm-kernel@lists.infradead.org,
Baruch Siach <baruch@tkos.co.il>,
Sudeep Holla <sudeep.holla@arm.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>
Subject: Re: [PATCH 1/5] gpio: pl061: use local state for parent IRQ storage
Date: Thu, 1 Dec 2016 13:48:08 +0000 [thread overview]
Message-ID: <be5a081a-24d7-ff50-d8c5-01e02e64a5dc@arm.com> (raw)
In-Reply-To: <1480068564-9447-1-git-send-email-linus.walleij@linaro.org>
On 25/11/16 10:09, Linus Walleij wrote:
> The driver is poking around in the struct gpio_chip internals,
> which is a no-no. Use a variable in the local state container.
>
The entire series looks good to me. I also gave it a spin on my Juno. So,
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Tested-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
prev parent reply other threads:[~2016-12-01 13:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 10:09 [PATCH 1/5] gpio: pl061: use local state for parent IRQ storage Linus Walleij
2016-11-25 10:09 ` [PATCH 2/5] gpio: pl061: rename state container struct Linus Walleij
2016-11-25 10:09 ` [PATCH 3/5] gpio: pl061: rename variable from chip to pl061 Linus Walleij
2016-11-25 10:09 ` [PATCH 4/5] gpio: pl061: move platform data into driver Linus Walleij
2016-11-25 10:09 ` [PATCH 5/5] gpio: pl061: delete platform data handling Linus Walleij
2016-12-01 13:48 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be5a081a-24d7-ff50-d8c5-01e02e64a5dc@arm.com \
--to=sudeep.holla@arm.com \
--cc=acourbot@nvidia.com \
--cc=baruch@tkos.co.il \
--cc=haojian.zhuang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).